Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-16170: Add support for Intel X710 Backplane and Base T #802

Merged
merged 1 commit into from
Jul 17, 2023
Merged

OCPBUGS-16170: Add support for Intel X710 Backplane and Base T #802

merged 1 commit into from
Jul 17, 2023

Conversation

SalDaniele
Copy link
Contributor

Backport #794 to 4.13

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 13, 2023
@openshift-ci-robot
Copy link
Contributor

@SalDaniele: This pull request references Jira Issue OCPBUGS-16170, which is invalid:

  • expected Jira Issue OCPBUGS-16170 to depend on a bug targeting a version in 4.14.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Backport #794 to 4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@SalDaniele
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@SalDaniele: This pull request references Jira Issue OCPBUGS-16170, which is invalid:

  • expected the bug to be open, but it isn't
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Closed (Done) instead
  • expected dependent Jira Issue OCPBUGS-16183 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is New instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@SalDaniele
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 13, 2023
@openshift-ci-robot
Copy link
Contributor

@SalDaniele: This pull request references Jira Issue OCPBUGS-16170, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.z) matches configured target version for branch (4.13.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-16183 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-16183 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0
  • bug has dependents

Requesting review from QA contact:
/cc @zhaozhanqi

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from zhaozhanqi July 13, 2023 15:18
@SalDaniele
Copy link
Contributor Author

@zhaozhanqi @wizhaoredhat PTAL, need approvals to backport #794 to 4.13

@SalDaniele SalDaniele mentioned this pull request Jul 13, 2023
Closed
@wizhaoredhat
Copy link
Contributor

/approved
/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 13, 2023
@wizhaoredhat
Copy link
Contributor

/label cherry-pick-approved

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 13, 2023

@wizhaoredhat: Can not set label cherry-pick-approved: Must be member in one of these teams: []

In response to this:

/label cherry-pick-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wizhaoredhat
Copy link
Contributor

/label backport-risk-assessed

wizhaoredhat
wizhaoredhat reviewed Jul 13, 2023
View reviewed changes
doc/supported-hardware.md Outdated
@@ -54,6 +61,7 @@ The following table depicts the supported SR-IOV hardware features of each suppo
| Mellanox MT28908 Family [ConnectX-6 Lx] | V | V | V |
| Mellanox MT28908 Family [ConnectX-7] | V | V | V |
| Mellanox MT42822 BlueField-2 integrated ConnectX-6 Dx | V | V | V |
| Mellanox MT43244 BlueField-3 integrated ConnectX-6 Dx | V | V | V |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we accidentally pull in another commit?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I was a bit confused by this inclusion. Not sure if this was intentional. I will remove this for now, if we need to backport cx-7 support we can do this in a separate PR

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 13, 2023
@wizhaoredhat
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 13, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SalDaniele, wizhaoredhat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 13, 2023

@SalDaniele: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-nfv 80a7fa5 link false /test e2e-openstack-nfv

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wizhaoredhat
Copy link
Contributor

@zhaozhanqi Could you provide your approval?

@zhaozhanqi
Copy link

need label backport-risk-assessed firstly, and then I can /label cherry-pick-approved

@zhaozhanqi
Copy link

need label backport-risk-assessed firstly, and then I can /label cherry-pick-approved

sounds like backport-risk-assessed is failed to add :)

@wizhaoredhat
Copy link
Contributor

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jul 14, 2023
@wizhaoredhat
Copy link
Contributor

need label backport-risk-assessed firstly, and then I can /label cherry-pick-approved

sounds like backport-risk-assessed is failed to add :)

Should be good now.

@zhaozhanqi
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 17, 2023
@openshift-merge-robot openshift-merge-robot merged commit 238e007 into openshift:release-4.13 Jul 17, 2023
9 of 10 checks passed
@openshift-ci-robot
Copy link
Contributor

@SalDaniele: Jira Issue OCPBUGS-16170: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-16170 has been moved to the MODIFIED state.

In response to this:

Backport #794 to 4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wizhaoredhat wizhaoredhat wizhaoredhat left review comments

@zhaozhanqi zhaozhanqi Awaiting requested review from zhaozhanqi

@SchSeba SchSeba Awaiting requested review from SchSeba

@zshi-redhat zshi-redhat Awaiting requested review from zshi-redhat

Assignees

@mffiedler mffiedler

@rbbratta rbbratta

@weliang1 weliang1

@anuragthehatter anuragthehatter

@huiran0826 huiran0826

@asood-rh asood-rh

@jechen0648 jechen0648

@yingwang-0320 yingwang-0320

@wizhaoredhat wizhaoredhat

@qiowang721 qiowang721

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet