OCPBUGS-19440: [release-4.14]: SriovNetwork, SriovIBNetwork, react on namespace creation #830

zeeke · 2023-09-20T09:07:06Z

Backport of:

SriovNetwork: react on namespace creation k8snetworkplumbingwg/sriov-network-operator#493

If a user creates an SriovNetwork with a network namespace that doesn't exist, retrying reconciling with an exponential backoff is not efficient, as the routing will fail until the namespace is created. This patch makes the controller watch Namespace resource creation and reconcile the related SriovNetworks if needed. Signed-off-by: Andrea Panattoni <apanatto@redhat.com>

Apply the same namespace reaction as the SriovNetwork Signed-off-by: Andrea Panattoni <apanatto@redhat.com>

zeeke · 2023-09-20T09:07:24Z

/jira cherrypick OCPBUGS-8266

openshift-ci-robot · 2023-09-20T09:07:31Z

@zeeke: Jira Issue OCPBUGS-8266 has been cloned as Jira Issue OCPBUGS-19440. Will retitle bug to link to clone.
/retitle OCPBUGS-19440: [release-4.14]: SriovNetwork, SriovIBNetwork, react on namespace creation

In response to this:

/jira cherrypick OCPBUGS-8266

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-09-20T09:08:24Z

@zeeke: This pull request references Jira Issue OCPBUGS-19440, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.14.0) matches configured target version for branch (4.14.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
dependent bug Jira Issue OCPBUGS-8266 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
dependent Jira Issue OCPBUGS-8266 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0
bug has dependents

Requesting review from QA contact:
/cc @zhaozhanqi

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Backport of:

SriovNetwork: react on namespace creation k8snetworkplumbingwg/sriov-network-operator#493

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-09-20T11:11:46Z

@zeeke: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-openstack-nfv	`0f2e783`	link	false	`/test e2e-openstack-nfv`
ci/prow/e2e-openstack-nfv-hwoffload	`0f2e783`	link	false	`/test e2e-openstack-nfv-hwoffload`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

zeeke · 2023-09-26T12:19:50Z

@bn222 , @SchSeba Please take a look

bn222 · 2023-09-26T13:03:18Z

controllers/sriovnetwork_controller.go

@@ -173,8 +182,31 @@ func (r *SriovNetworkReconciler) Reconcile(ctx context.Context, req ctrl.Request

 // SetupWithManager sets up the controller with the Manager.
 func (r *SriovNetworkReconciler) SetupWithManager(mgr ctrl.Manager) error {
+	// Reconcile when the target namespace is created after the SriovNetwork object.


please also CC me next time on the upstream discussion.

Fine. Do you mean for every change in the operator? Or for controllers one?
Most of the discussions are held in upstream meetings on Monday and Tuesday

Every change

bn222 · 2023-09-26T13:03:53Z

controllers/sriovnetwork_controller.go

+					Name:      network.Name,
+				}})
+			}
+		},


I would have been nicer if this wasn't defined inline.

I guess I can propose a refactor upstream

Refactor network controller namespace handlers k8snetworkplumbingwg/sriov-network-operator#513

wizhaoredhat · 2023-09-27T18:23:35Z

/approved

bn222 · 2023-09-28T06:28:53Z

/approve

zeeke · 2023-10-04T10:42:45Z

@SchSeba please take a look. We need backport-risk-assessed
@zhaozhanqi we also need cherry-pick-approved

zhaozhanqi · 2023-11-02T01:51:33Z

also cc @bn222 @wizhaoredhat for backport-risk-assessed
I will add cherry-pick-approved

wizhaoredhat · 2023-11-02T02:00:32Z

/label backport-risk-assessed

wizhaoredhat · 2023-11-02T02:00:52Z

/lgtm

openshift-ci · 2023-11-02T02:02:34Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bn222, wizhaoredhat, zeeke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [bn222,wizhaoredhat]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

zhaozhanqi · 2023-11-02T02:15:51Z

/label cherry-pick-approved

openshift-ci-robot · 2023-11-02T03:23:52Z

/retest-required

Remaining retests: 0 against base HEAD aad6c5b and 2 for PR HEAD 0f2e783 in total

openshift-ci-robot · 2023-11-02T03:35:39Z

@zeeke: Jira Issue OCPBUGS-19440: All pull requests linked via external trackers have merged:

openshift/sriov-network-operator#830

Jira Issue OCPBUGS-19440 has been moved to the MODIFIED state.

In response to this:

Backport of:

SriovNetwork: react on namespace creation k8snetworkplumbingwg/sriov-network-operator#493

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

zeeke · 2023-11-02T08:08:25Z

/cherrypick release-4.13

openshift-cherrypick-robot · 2023-11-02T08:09:10Z

@zeeke: #830 failed to apply on top of branch "release-4.13":

Applying: SriovNetwork: react on namespace creation
Using index info to reconstruct a base tree...
M	controllers/sriovnetwork_controller.go
M	controllers/sriovnetwork_controller_test.go
M	controllers/suite_test.go
M	main.go
Falling back to patching base and 3-way merge...
Auto-merging main.go
Auto-merging controllers/suite_test.go
Auto-merging controllers/sriovnetwork_controller_test.go
Auto-merging controllers/sriovnetwork_controller.go
CONFLICT (content): Merge conflict in controllers/sriovnetwork_controller.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 SriovNetwork: react on namespace creation
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

zeeke added 2 commits September 20, 2023 11:05

SriovIBetwork: react on namespace creation

0f2e783

Apply the same namespace reaction as the SriovNetwork Signed-off-by: Andrea Panattoni <apanatto@redhat.com>

openshift-ci bot changed the title ~~[release-4.14]: SriovNetwork, SriovIBNetwork, react on namespace creation~~ OCPBUGS-19440: [release-4.14]: SriovNetwork, SriovIBNetwork, react on namespace creation Sep 20, 2023

openshift-ci bot requested review from zhaozhanqi, SchSeba and wizhaoredhat September 20, 2023 09:08

bn222 reviewed Sep 26, 2023

View reviewed changes

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 28, 2023

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Nov 2, 2023

openshift-ci bot assigned anuragthehatter, asood-rh, huiran0826, jechen0648, mffiedler, qiowang721 and rbbratta Nov 2, 2023

openshift-ci bot assigned weliang1, yingwang-0320 and zhaozhanqi Nov 2, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 2, 2023

openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Nov 2, 2023

openshift-ci bot merged commit 514df18 into openshift:release-4.14 Nov 2, 2023
9 of 11 checks passed

zeeke mentioned this pull request Nov 23, 2023

OCPBUGS-23059: [release-4.13]: SriovNetwork, SriovIBNetwork, react on namespace creation #860

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OCPBUGS-19440: [release-4.14]: SriovNetwork, SriovIBNetwork, react on namespace creation #830

OCPBUGS-19440: [release-4.14]: SriovNetwork, SriovIBNetwork, react on namespace creation #830

zeeke commented Sep 20, 2023

zeeke commented Sep 20, 2023

openshift-ci-robot commented Sep 20, 2023

openshift-ci-robot commented Sep 20, 2023

openshift-ci bot commented Sep 20, 2023

zeeke commented Sep 26, 2023

bn222 Sep 26, 2023

zeeke Sep 27, 2023

bn222 Sep 28, 2023

bn222 Sep 26, 2023

zeeke Sep 27, 2023

zeeke Sep 28, 2023

wizhaoredhat commented Sep 27, 2023

bn222 commented Sep 28, 2023

zeeke commented Oct 4, 2023

zhaozhanqi commented Nov 2, 2023

wizhaoredhat commented Nov 2, 2023

wizhaoredhat commented Nov 2, 2023

openshift-ci bot commented Nov 2, 2023

zhaozhanqi commented Nov 2, 2023

openshift-ci-robot commented Nov 2, 2023

openshift-ci-robot commented Nov 2, 2023

zeeke commented Nov 2, 2023

openshift-cherrypick-robot commented Nov 2, 2023

OCPBUGS-19440: [release-4.14]: SriovNetwork, SriovIBNetwork, react on namespace creation #830

OCPBUGS-19440: [release-4.14]: SriovNetwork, SriovIBNetwork, react on namespace creation #830

Conversation

zeeke commented Sep 20, 2023

zeeke commented Sep 20, 2023

openshift-ci-robot commented Sep 20, 2023

openshift-ci-robot commented Sep 20, 2023

openshift-ci bot commented Sep 20, 2023

zeeke commented Sep 26, 2023

bn222 Sep 26, 2023

Choose a reason for hiding this comment

zeeke Sep 27, 2023

Choose a reason for hiding this comment

bn222 Sep 28, 2023

Choose a reason for hiding this comment

bn222 Sep 26, 2023

Choose a reason for hiding this comment

zeeke Sep 27, 2023

Choose a reason for hiding this comment

zeeke Sep 28, 2023

Choose a reason for hiding this comment

wizhaoredhat commented Sep 27, 2023

bn222 commented Sep 28, 2023

zeeke commented Oct 4, 2023

zhaozhanqi commented Nov 2, 2023

wizhaoredhat commented Nov 2, 2023

wizhaoredhat commented Nov 2, 2023

openshift-ci bot commented Nov 2, 2023

zhaozhanqi commented Nov 2, 2023

openshift-ci-robot commented Nov 2, 2023

openshift-ci-robot commented Nov 2, 2023

zeeke commented Nov 2, 2023

openshift-cherrypick-robot commented Nov 2, 2023