OCPBUGS-19908: Downstream sync 2023-10-23 #842
Conversation
We use Kontron ME1310 Edge Servers which has built in E823C NICs. We create VFs using these NICs. We are able to create SriovNetworkNodePolicy and create the VFs after adding it under supported-nic-ids config map
Add support for Intel E823C NICs
We can't rely on the PCI address from the metadata so we will lookup the real PCI address for the NIC that matches the MAC address. Libvirt/QEMU cannot guarantee that the address specified in the XML will match the address seen by the guest. This is a well known limitation: https://libvirt.org/pci-addresses.html When using the q35 machine type, it highlights this issue due to the change from using PCI to PCI-E bus for virtual devices. With that said, the PCI value in Nova Metadata is a best effort hint due to the limitations mentioned above. Therefore we will lookup the real PCI address for the NIC that matches the MAC address.
Co-Authored-By: Andrea Panattoni <apanatto@redhat.com> Co-Authored-By: Emilien Macchi <emilien@redhat.com>
https://devicehunt.com/view/type/pci/vendor/1AF4/device/1041 https://qemu.readthedocs.io/en/master/specs/pci-ids.html Modern QEMU brings up virtio 1.0 network device, we need to support that for DPDK.
virtual: get real PCI address for each device found
Updates to OCP: * add a retry to the policy create to fix OCP CI flake * add more ram to the OCP master single node * add a wait for registry to be available * update the ocp version to latest 4.14 rc release Updates for K8s: * switch to not use dockerhub for the registry image to overcome the pull limit * add alias for golang to the dockerhub image github actions: * always remove the cluster Signed-off-by: Sebastian Sch <sebassch@gmail.com>
CI scripts improvements
via command: ``` make -f Makefile.bundle generate bundle ``` Signed-off-by: Andrea Panattoni <apanatto@redhat.com>
openshift-ci-robot
added
jira/valid-reference
|
@zeeke: This pull request references Jira Issue OCPBUGS-19908, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (zgreenbe@redhat.com), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
/retest-required |
|
/lgtm |
|
out of curiosity but not blocking it: |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bn222, mlguerrero12, zeeke The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@zeeke: Jira Issue OCPBUGS-19908: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-19908 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@zeeke: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@zeeke could we have a sync on 4.14 also, thanks. |
There is no sync for older branches. We can cherry-pick specific commits and create a pull request targeting release-4.14 |
clean merge from upstream without conflicts
ran
make -f Makefile.bundle generate bundleto align downstream manifests forexternallyManagedfield in sriovnetworknodestate and sriovnetworknodepolicy (cc @SchSeba)vlanProtofield in sriovnetwork (cc @mlguerrero12)cc @EmilienM