Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-24231: Fix config daemon annotation override #873

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

cgoncalves
Copy link
Contributor

A downstream merge [1][2] overrode the annotations in the config daemonset. This resulted in he sriov-network-config-daemon pod missing the target.workload.openshift.io/management annotation which led to the pod not being pinned to the management cores when workload partitioning is enabled.

This is a downstream-only patch.

[1] #868
[2] commit 0f17753

A downstream merge [1][2] overrode the annotations in the config
daemonset. This resulted in he sriov-network-config-daemon pod missing
the `target.workload.openshift.io/management` annotation which led to
the pod not being pinned to the management cores when workload
partitioning is enabled.

This is a downstream-only patch.

[1] openshift#868
[2] commit 0f17753

Signed-off-by: Carlos Goncalves <cgoncalves@redhat.com>
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 13, 2023
@openshift-ci-robot
Copy link
Contributor

@cgoncalves: This pull request references Jira Issue OCPBUGS-24231, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

A downstream merge [1][2] overrode the annotations in the config daemonset. This resulted in he sriov-network-config-daemon pod missing the target.workload.openshift.io/management annotation which led to the pod not being pinned to the management cores when workload partitioning is enabled.

This is a downstream-only patch.

[1] #868
[2] commit 0f17753

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cgoncalves
Copy link
Contributor Author

/cherry-pick release-4.15

@openshift-cherrypick-robot

@cgoncalves: once the present PR merges, I will cherry-pick it on top of release-4.15 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cgoncalves
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 13, 2023
@openshift-ci-robot
Copy link
Contributor

@cgoncalves: This pull request references Jira Issue OCPBUGS-24231, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @zhaozhanqi

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

openshift-ci bot commented Dec 13, 2023

@cgoncalves: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zeeke
Copy link
Contributor

zeeke commented Dec 14, 2023

/lgtm

@SchSeba , @wizhaoredhat please take a look

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 14, 2023
@wizhaoredhat
Copy link
Contributor

/lgtm

Copy link
Contributor

openshift-ci bot commented Dec 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgoncalves, wizhaoredhat, zeeke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 14, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit 16e5d7b into openshift:master Dec 14, 2023
10 checks passed
@openshift-ci-robot
Copy link
Contributor

@cgoncalves: Jira Issue OCPBUGS-24231: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-24231 has been moved to the MODIFIED state.

In response to this:

A downstream merge [1][2] overrode the annotations in the config daemonset. This resulted in he sriov-network-config-daemon pod missing the target.workload.openshift.io/management annotation which led to the pod not being pinned to the management cores when workload partitioning is enabled.

This is a downstream-only patch.

[1] #868
[2] commit 0f17753

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@cgoncalves: new pull request created: #874

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build sriov-network-config-daemon-container-v4.16.0-202312141929.p0.g16e5d7b.assembly.stream for distgit sriov-network-config-daemon.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build sriov-network-webhook-container-v4.16.0-202312141929.p0.g16e5d7b.assembly.stream for distgit sriov-network-webhook.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build sriov-network-operator-container-v4.16.0-202312141929.p0.g16e5d7b.assembly.stream for distgit sriov-network-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants