Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/oauth2: consider session cancellation #182

Merged
merged 6 commits into from Jun 13, 2019
Merged

pkg/oauth2: consider session cancellation #182

merged 6 commits into from Jun 13, 2019

Commits on Jun 7, 2019

  1. pkg/oauth2: add unit test for session expiry

    @s-urbaniak
    s-urbaniak committed Jun 7, 2019
    Configuration menu
    Copy the full SHA
    7c219eb View commit details
    Browse the repository at this point in the history

  2. pkg/oauth2: consider session cancellation 

    Currently, if telemeter assumes a refresh token is still valid,
it will treat errors from fetching an access token as fatal.

In reality, the authorization server might have reset our session
and invalidate the refresh token server-side despite still being valid.

In that case it returns a 400 status code.

This fixes it.

Fixes MON-690
    @s-urbaniak
    s-urbaniak committed Jun 7, 2019
    Configuration menu
    Copy the full SHA
    b4f1fa8 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2019

  1. pkg/oauth2: add pwd credentials grants total metrics

    @s-urbaniak
    s-urbaniak committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    36c72d7 View commit details
    Browse the repository at this point in the history

  2. pkg/oauth2: dependency-inject grants total counter metric

    @s-urbaniak
    s-urbaniak committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    b10ffcf View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2019

  1. pkg/oauth2: dependency inject counter interface

    @s-urbaniak
    s-urbaniak committed Jun 13, 2019
    Configuration menu
    Copy the full SHA
    71867d0 View commit details
    Browse the repository at this point in the history

  2. pkg/oauth2: set cause/status labels 

    This gives us more insights on
a) why the refresh token was re-issued (cause label)
b) if the operation failed (status label)
    @s-urbaniak
    s-urbaniak committed Jun 13, 2019
    Configuration menu
    Copy the full SHA
    fe20139 View commit details
    Browse the repository at this point in the history