Bug 1744017: pkg/forwarder: dont proxy in-cluster requests #226
Conversation
Currently, requests to the in-cluster Prometheus respect the environment variable proxy configuration just as requests to telemeter server respect it. This means that when the proxy configuration is set, requests to scrape the in-cluster prometheus will fail. This commit fixes the configuration so only outbound requests are proxied.
openshift-ci-robot
added
approved
squat
changed the title
|
@squat: This pull request references Bugzilla bug 1744017, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: s-urbaniak, squat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@squat: All pull requests linked via external trackers have merged. Bugzilla bug 1744017 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Currently, requests to the in-cluster Prometheus respect the environment
variable proxy configuration just as requests to telemeter server
respect it. This means that when the proxy configuration is set,
requests to scrape the in-cluster prometheus will fail. This commit
fixes the configuration so only outbound requests are proxied.
cc @kakkoyun @metalmatze @s-urbaniak