Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsonnet/telemeter: monitor memcached #280

Merged
merged 1 commit into from Dec 13, 2019

Conversation

squat
Copy link
Contributor

@squat squat commented Dec 12, 2019

This commit introduces the memcached-exporter so that we can monitor
memcached. It also introduces some controls on the memcached process,
modeled after the grafana memcached jsonnet library:
https://github.com/grafana/jsonnet-libs/tree/master/memcached.

Signed-off-by: Lucas Servén Marín lserven@gmail.com

cc @metalmatze @brancz @kakkoyun

This commit introduces the memcached-exporter so that we can monitor
memcached. It also introduces some controls on the memcached process,
modeled after the grafana memcached jsonnet library:
https://github.com/grafana/jsonnet-libs/tree/master/memcached.

Signed-off-by: Lucas Servén Marín <lserven@gmail.com>
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2019
@squat squat changed the title jsonnet.telemeter: monitor memcached jsonnet/telemeter: monitor memcached Dec 12, 2019
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 12, 2019
@squat
Copy link
Contributor Author

squat commented Dec 12, 2019

/test e2e-aws-upgrade

@brancz
Copy link
Contributor

brancz commented Dec 13, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 13, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brancz, squat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 915f847 into openshift:master Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants