Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add first Telemeter recording rules #286

Merged
merged 2 commits into from Dec 19, 2019
Merged

Add first Telemeter recording rules #286

merged 2 commits into from Dec 19, 2019

Conversation

kakkoyun
Copy link
Contributor

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2019
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 18, 2019
@kakkoyun
Copy link
Contributor Author

/test e2e-aws

squat
squat approved these changes Dec 19, 2019
View reviewed changes
Copy link
Contributor

@squat squat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Awesome!

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 19, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kakkoyun, squat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@squat
Copy link
Contributor

squat commented Dec 19, 2019

/retest

@openshift-merge-robot openshift-merge-robot merged commit 04e8962 into openshift:master Dec 19, 2019
@kakkoyun kakkoyun deleted the add_example_recording_rules branch December 19, 2019 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squat squat squat approved these changes

@lilic lilic Awaiting requested review from lilic

Assignees

@squat squat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kakkoyun @openshift-ci-robot @squat @openshift-merge-robot