Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/receive: return correct status code #299

Merged
merged 1 commit into from Jan 22, 2020

Conversation

squat
Copy link
Contributor

@squat squat commented Jan 21, 2020

status code, i.e. it does not overwrite the status code returned by the
downstream handler.

Signed-off-by: Lucas Servén Marín lserven@gmail.com

cc @metalmatze @brancz @kakkoyun @bwplotka

status code, i.e. it does not overwrite the status code returned by the
downstream handler.

Signed-off-by: Lucas Servén Marín <lserven@gmail.com>
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 21, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 21, 2020
@metalmatze
Copy link
Contributor

Did you check what happens now if we actually have a gateway timeout?

@squat
Copy link
Contributor Author

squat commented Jan 21, 2020

If there's a gateway timeout, then err is not nil, so we hit this line of code:

http.Error(w, err.Error(), http.StatusBadGateway)

@brancz
Copy link
Contributor

brancz commented Jan 21, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2020
@brancz
Copy link
Contributor

brancz commented Jan 21, 2020

/retest

Copy link
Contributor

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brancz, bwplotka, squat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [brancz,bwplotka,squat]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@squat
Copy link
Contributor Author

squat commented Jan 21, 2020

/retest

@openshift-merge-robot openshift-merge-robot merged commit f64b1ae into openshift:master Jan 22, 2020
@bwplotka
Copy link
Contributor

As a side note this is something we can improve: Ideally we should use something like httputil.ReverseProxy which would handle all those things automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants