New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg/receive: return correct status code #299
pkg/receive: return correct status code #299
Conversation
status code, i.e. it does not overwrite the status code returned by the downstream handler. Signed-off-by: Lucas Servén Marín <lserven@gmail.com>
Did you check what happens now if we actually have a gateway timeout? |
If there's a gateway timeout, then telemeter/pkg/receive/handler.go Line 63 in 9562123
|
/lgtm |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brancz, bwplotka, squat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
As a side note this is something we can improve: Ideally we should use something like httputil.ReverseProxy which would handle all those things automatically. |
status code, i.e. it does not overwrite the status code returned by the
downstream handler.
Signed-off-by: Lucas Servén Marín lserven@gmail.com
cc @metalmatze @brancz @kakkoyun @bwplotka