Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1813221: jsonnet/telemeter: set cpu requests, unset limits #320

Merged
merged 4 commits into from Mar 26, 2020
Merged

Bug 1813221: jsonnet/telemeter: set cpu requests, unset limits #320

merged 4 commits into from Mar 26, 2020

Conversation

s-urbaniak
Copy link
Contributor

/cc @openshift/openshift-team-monitoring

@openshift-ci-robot openshift-ci-robot requested a review from a team March 24, 2020 12:25
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2020
@openshift-ci-robot
Copy link
Contributor

@s-urbaniak: This pull request references Bugzilla bug 1813221, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.4.0) matches configured target release for branch (4.4.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1812719 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1812719 targets the "4.5.0" release, matching the expected (4.5.0) release
  • bug has dependents

In response to this:

Bug 1813221: jsonnet/telemeter: set cpu requests, unset limits

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Mar 24, 2020
squat
squat reviewed Mar 24, 2020
View reviewed changes
manifests/client/deployment.yaml
requests:
cpu: 10m
cpu: 1m
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this enough?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for kube-rbac-proxy, yes, i measured it on a local e2e prometheus dump

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack, looks like this was set as the request for every container in the pod. Even thought it's just a request, I don't think it's enough for telemeter client

@paulfantom
Copy link
Contributor

/lgtm
/retest

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 24, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@squat
Copy link
Contributor

squat commented Mar 24, 2020

it looks like this PR is built on top of a very old parent commit, which is why the integration tests are failing. Plz rebase and the tests should start passing

@s-urbaniak
Copy link
Contributor Author

@squat hmm, this is based on the newest release-4.4 commit:

* 16bddf7b - (HEAD -> cpu-requests, s-urbaniak/cpu-requests) assets: regenerate (32 minutes ago) <Sergiusz Urbaniak>
* 225391ac - jsonnet/telemeter: set cpu requests, unset limits (33 minutes ago) <Sergiusz Urbaniak>
*   7853182e - (origin/release-4.4, bz-1794616) Merge pull request #306 from brancz/move-metrics-whitelist (7 weeks ago) <OpenShift Merge

@squat
Copy link
Contributor

squat commented Mar 24, 2020

yes, doesn't matter :) the dependency used in integration tests in ALL branches moved and needs to be fixed. You need this PR: #317

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 24, 2020
@s-urbaniak
Copy link
Contributor Author

ok, cherry-picked #317 commits, let's see how this goes.

@brancz
Copy link
Contributor

brancz commented Mar 24, 2020

looks good to me but having @squat review the cherry-pick

/lgtm
/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 24, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 24, 2020
@squat
Copy link
Contributor

squat commented Mar 24, 2020

To keep the backport as minimal as possible, let's drop commit bf34f2c, it's not needed

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2020
@s-urbaniak
Copy link
Contributor Author

@squat fixed, PTAL

squat
squat approved these changes Mar 25, 2020
View reviewed changes
Copy link
Contributor

@squat squat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks mostly good to me, however I think 1m CPU request is undersized for the telemeter-client container

@s-urbaniak
Copy link
Contributor Author

@squat telemeter-client container peaks at 0.3 millicores
image

This is data taken from a e2e test run which we take as the reference.

ptal

@squat
Copy link
Contributor

squat commented Mar 26, 2020

excellent :)

@s-urbaniak
Copy link
Contributor Author

@squat or anybody out there, can i have a /lgtm please? :)

@brancz
Copy link
Contributor

brancz commented Mar 26, 2020

/lgtm
/retest

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brancz, paulfantom, s-urbaniak, squat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [brancz,paulfantom,s-urbaniak,squat]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@s-urbaniak
Copy link
Contributor Author

/retest
/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 26, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@s-urbaniak s-urbaniak added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 26, 2020
@s-urbaniak
Copy link
Contributor Author

setting cherry-pick approval as this is a jsonnet library change only which will be vendored into cluster-monitoring-operator.

@openshift-merge-robot openshift-merge-robot merged commit debbf86 into openshift:release-4.4 Mar 26, 2020
@openshift-ci-robot
Copy link
Contributor

@s-urbaniak: Some pull requests linked via external trackers have merged: . The following pull requests linked via external trackers have not merged:

In response to this:

Bug 1813221: jsonnet/telemeter: set cpu requests, unset limits

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@s-urbaniak s-urbaniak deleted the cpu-requests branch March 27, 2020 13:08
@openshift-ci-robot openshift-ci-robot mentioned this pull request Apr 6, 2020
Merged
@openshift-ci-robot openshift-ci-robot mentioned this pull request Apr 16, 2020
Merged
@openshift-ci-robot openshift-ci-robot mentioned this pull request May 7, 2020
Merged
@openshift-ci-robot openshift-ci-robot mentioned this pull request Jun 19, 2020
Merged
This was referenced Jul 3, 2020
Merged
Merged
@simonpasquier simonpasquier mentioned this pull request Jul 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squat squat squat approved these changes

Assignees

@paulfantom paulfantom

@brancz brancz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@s-urbaniak @openshift-ci-robot @paulfantom @openshift-bot @squat @brancz @openshift-merge-robot @metalmatze