New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1905330: jsonnet: add memory requests to client containers #370
Bug 1905330: jsonnet: add memory requests to client containers #370
Conversation
Signed-off-by: Damien Grisonnet <dgrisonn@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgrisonnet, paulfantom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
/rename Bug 1905330: jsonnet: add memory requests to client containers you need valid bugzilla, lets see if this works :D |
/shrug guess you have to do it manually :) |
@dgrisonnet: This pull request references Bugzilla bug 1905330, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@dgrisonnet: This pull request references Bugzilla bug 1905330, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Indeed, thank you for the reminder @lilic 🙂 |
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
@dgrisonnet: All pull requests linked via external trackers have merged: Bugzilla bug 1905330 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
As reported in https://bugzilla.redhat.com/show_bug.cgi?id=1905330 we must set the memory requests of the
telemeter-client
andreload
containers before openshift/origin#25747 lands./cc @openshift/openshift-team-monitoring