Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add volume metrics jsonnet #457

Closed
wants to merge 2 commits into from
Closed

Add volume metrics jsonnet #457

wants to merge 2 commits into from

Conversation

marioferh
Copy link
Contributor

@marioferh marioferh commented Apr 11, 2023 •
edited

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 11, 2023
@marioferh marioferh changed the title WIP Add metrics jsonnet WIP Add volume metrics jsonnet Apr 11, 2023
@marioferh marioferh mentioned this pull request Apr 11, 2023
Merged
4 tasks
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 11, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: marioferh
Once this PR has been reviewed and has the lgtm label, please assign sthaha for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@marioferh
Add metrics mount to telemter client
9783ade 
Signed-off-by: Mario Fernandez <mariofer@redhat.com>
@marioferh
Copy link
Contributor Author

/retest

@marioferh marioferh changed the title WIP Add volume metrics jsonnet Add volume metrics jsonnet Apr 21, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 21, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 2, 2023

@marioferh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@marioferh marioferh closed this Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipgough philipgough Awaiting requested review from philipgough

@saswatamcode saswatamcode Awaiting requested review from saswatamcode

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marioferh @openshift-merge-robot