Improve debug roundtripper logs #467
Conversation
Signed-off-by: Mario Fernandez <mariofer@redhat.com>
| level.Debug(rt.logger).Log("msg", "round trip", "requestdump", string(reqd)) | ||
| level.Debug(rt.logger).Log("msg", "round trip", "requestbody", reqBody) | ||
| level.Debug(rt.logger).Log("msg", "round trip", "responsedump", string(resd)) | ||
| level.Debug(rt.logger).Log("msg", "round trip", "responsebody", resBody) |
There was a problem hiding this comment.
this one is so long and not legible, any suggestion in order to clean it? thanks
There was a problem hiding this comment.
Hmm, I don't think breaking up resBody beyond this would be a good thing. Let's merge and iterate!
There was a problem hiding this comment.
Yes, next iteration is to fix the body output indent. With fmt.Println is correct, but when the string is passed to logger the output is ruined. I have been trying to fix it but I have not find a easy and fast way to do it.
|
@marioferh: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| level.Debug(rt.logger).Log("msg", "round trip", "requestdump", string(reqd)) | ||
| level.Debug(rt.logger).Log("msg", "round trip", "requestbody", reqBody) | ||
| level.Debug(rt.logger).Log("msg", "round trip", "responsedump", string(resd)) | ||
| level.Debug(rt.logger).Log("msg", "round trip", "responsebody", resBody) |
There was a problem hiding this comment.
Hmm, I don't think breaking up resBody beyond this would be a good thing. Let's merge and iterate!
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: marioferh, saswatamcode The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: marioferh, saswatamcode The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Improve debug roundtripper logs splitting in different lines