Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-16397: Nutanix OCP cluster telemetry data "host_type" shows "virt-unknown" #474

Merged
merged 1 commit into from Aug 11, 2023
Merged

OCPBUGS-16397: Nutanix OCP cluster telemetry data "host_type" shows "virt-unknown" #474

merged 1 commit into from Aug 11, 2023

Conversation

yanhua121
Copy link
Contributor

This is to fix OCPBUGS-16397: Nutanix OCP cluster telemetry data "host_type" shows "virt-unknown".
Similar to other cloud providers, Nutanix also need to identify its "host_type" in the telemetry data. Refer to #356.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 25, 2023
@openshift-ci-robot
Copy link
Contributor

@yanhua121: This pull request references Jira Issue OCPBUGS-16397, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @gpei

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is to fix OCPBUGS-16397: Nutanix OCP cluster telemetry data "host_type" shows "virt-unknown".
Similar to other cloud providers, Nutanix also need to identify its "host_type" in the telemetry data. Refer to #356.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jul 25, 2023
@yanhua121
Copy link
Contributor Author

/retest-required

simonpasquier
simonpasquier reviewed Aug 11, 2023
View reviewed changes
Copy link
Contributor

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 11, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: simonpasquier, yanhua121

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 11, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD fa1d2b5 and 2 for PR HEAD 56dab65 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 11, 2023

@yanhua121: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 36999a3 into openshift:master Aug 11, 2023
10 checks passed
@openshift-ci-robot
Copy link
Contributor

@yanhua121: Jira Issue OCPBUGS-16397: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-16397 has been moved to the MODIFIED state.

In response to this:

This is to fix OCPBUGS-16397: Nutanix OCP cluster telemetry data "host_type" shows "virt-unknown".
Similar to other cloud providers, Nutanix also need to identify its "host_type" in the telemetry data. Refer to #356.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 11, 2023

/test remaining-required

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.14.0-0.nightly-2023-09-11-201102

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.14.0-0.nightly-2023-09-12-024050

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.14.0-0.nightly-2023-09-15-101929

@openshift-ci-robot openshift-ci-robot mentioned this pull request Feb 8, 2024
Merged
@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.16.0-0.nightly-2024-02-17-013806

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonpasquier simonpasquier simonpasquier left review comments

@gpei gpei Awaiting requested review from gpei

@philipgough philipgough Awaiting requested review from philipgough

@saswatamcode saswatamcode Awaiting requested review from saswatamcode

Assignees

@simonpasquier simonpasquier

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yanhua121 @openshift-ci-robot @openshift-merge-robot @simonpasquier