Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump github.com/prometheus/prometheus to v0.45.0 #475

Merged
merged 1 commit into from Aug 3, 2023
Merged

chore: bump github.com/prometheus/prometheus to v0.45.0 #475

merged 1 commit into from Aug 3, 2023

Conversation

simonpasquier
Copy link
Contributor

No description provided.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 28, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 28, 2023
@simonpasquier simonpasquier marked this pull request as ready for review August 1, 2023 15:00
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 1, 2023
@simonpasquier simonpasquier force-pushed the bump-prometheus branch 5 times, most recently from bb7ad03 to 5bc50cc Compare August 2, 2023 14:52
@simonpasquier
Copy link
Contributor Author

/test unit

saswatamcode
saswatamcode approved these changes Aug 3, 2023
View reviewed changes
Copy link
Member

@saswatamcode saswatamcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Generally LGTM! :)
Some comments.

pkg/runutil/runutil.go Show resolved Hide resolved
pkg/runutil/runutil.go
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can just use https://github.com/efficientgo/core/tree/main/runutil and remove completely? :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll keep the recommendation for a follow-up PR.

cmd/rhelemeter-server/main_e2e_test.go Outdated Show resolved Hide resolved
@simonpasquier
chore: bump github.com/prometheus/prometheus to v0.45.0
05ff73c 
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
@philipgough
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 3, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: philipgough, saswatamcode, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [philipgough,saswatamcode,simonpasquier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 3, 2023

@simonpasquier: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit fa1d2b5 into openshift:master Aug 3, 2023
10 checks passed
@simonpasquier simonpasquier deleted the bump-prometheus branch August 4, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipgough philipgough philipgough approved these changes

@saswatamcode saswatamcode saswatamcode approved these changes

@douglascamata douglascamata Awaiting requested review from douglascamata

@sthaha sthaha Awaiting requested review from sthaha

Assignees

@philipgough philipgough

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@simonpasquier @philipgough @saswatamcode @openshift-merge-robot