Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add machine424 and rexagod to OWNERS #478

Merged
merged 2 commits into from Oct 17, 2023
Merged

add machine424 and rexagod to OWNERS #478

merged 2 commits into from Oct 17, 2023

Conversation

rexagod
Copy link
Member

@rexagod rexagod commented Sep 13, 2023

simonpasquier
simonpasquier reviewed Sep 13, 2023
View reviewed changes
Copy link
Contributor

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sthaha and juanrh can be removed.

simonpasquier
simonpasquier reviewed Sep 13, 2023
View reviewed changes
Copy link
Contributor

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marioferh can be added too.

simonpasquier
simonpasquier reviewed Oct 16, 2023
View reviewed changes
Copy link
Contributor

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rexagod could you update the PR with my comments?

@rexagod
Copy link
Member Author

rexagod commented Oct 16, 2023 •
edited

I missed the notification for this, apologies for the delay here. I'll update all such PRs in all the repos.

@rexagod
Update OWNERS
5931ff8 
Move `juanrh` and `sthaha` to emeritus, and add ourselves, and Mario to approvers as well.
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 16, 2023

@rexagod: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jan--f
Copy link
Contributor

jan--f commented Oct 17, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jan--f, rexagod

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2023
@openshift-ci openshift-ci bot merged commit f4923fa into openshift:master Oct 17, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonpasquier simonpasquier simonpasquier left review comments

@jan--f jan--f Awaiting requested review from jan--f

Assignees

@jan--f jan--f

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rexagod @jan--f @simonpasquier