Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server: Add support for shipping traces to an otel collector #482

Merged

Conversation

douglascamata
Copy link
Member

@douglascamata douglascamata commented Oct 6, 2023

What's done in the PR:

  • Add support for telemeter/rhelemeter servers to ship traces in OTEL format to an OTEL collector.
    • Changes their integration tests to run an OTEL collector and ship traces to it.
  • Log request details using trace and span ids in both Telemeter (used a randomly generated request id before) and Rhelemeter.
    • We don't need to generate yet another request identifier if we already have the trace and span ids there. The proposal is to standardize around the traces.

Took some extra time to...

  • Upgrade Prometheus used in the integration tests from a release old enough that it didn't have a build for my OS/architecture to the most recent.
    • Gave up on this: it triggers failures in integration tests that are very difficult to fix due to a chain of dependency upgrades that are required.

Verification

Verified it works by running the integration tests with Rhelemeter on debug level and a local OTEL collector receiving the traces.

Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 6, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 6, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 6, 2023
@douglascamata douglascamata changed the title Add otel collector support Server: Add support for shipping traces to an otel collector Oct 6, 2023
@douglascamata douglascamata marked this pull request as ready for review October 9, 2023 09:32
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 9, 2023
@douglascamata
Copy link
Member Author

Seeing some weird CI failures and trying to investigate:

error: failed to push image registry.build01.ci.openshift.org/ci-op-lf1nky9g/release:latest: unable to upload new layer (0): Patch "https://registry.build01.ci.openshift.org/v2/ci-op-lf1nky9g/release/blobs/uploads/1dd4cd97-9b41-4af5-9227-96247ddba9c6?_state=VPkkGVZBjSd6-JxdpBszU2B6HnAClvm_D3B4wuTrO-F7Ik5hbWUiOiJjaS1vcC1sZjFua3k5Zy9yZWxlYXNlIiwiVVVJRCI6IjFkZDRjZDk3LTliNDEtNGFmNS05MjI3LTk2MjQ3ZGRiYTljNiIsIk9mZnNldCI6MCwiU3RhcnRlZEF0IjoiMjAyMy0xMC0wOVQwOTo0MDoxMy43MzEyNjU4MjlaIn0%3D": operator "cluster-network-operator" contained an invalid image-references file: no input image tag named "kuryr-cni"
{"component":"entrypoint","error":"wrapped process failed: exit status 1","file":"k8s.io/test-infra/prow/entrypoint/run.go:84","func":"k8s.io/test-infra/prow/entrypoint.Options.internalRun","level":"error","msg":"Error executing test process","severity":"error","time":"2023-10-09T09:40:14Z"} 

@douglascamata
Copy link
Member Author

Found the reason and solution to the build failures in openshift/cluster-network-operator#2056. Waiting for it to be merged.

@douglascamata
Copy link
Member Author

/retest-required

Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
@douglascamata douglascamata marked this pull request as draft October 9, 2023 15:24
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 9, 2023
Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
@douglascamata douglascamata marked this pull request as ready for review October 9, 2023 16:20
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 9, 2023
Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
@douglascamata
Copy link
Member Author

/test e2e-aws-upgrade

Copy link
Contributor

@philipgough philipgough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 10, 2023

@douglascamata: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@philipgough
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: douglascamata, philipgough

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [douglascamata,philipgough]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit ac3a9a0 into openshift:master Oct 10, 2023
10 checks passed
Copy link
Contributor

@moadz moadz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vendor files should be .gitignore'ed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants