New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Server: Add support for shipping traces to an otel collector #482
Server: Add support for shipping traces to an otel collector #482
Conversation
Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
Skipping CI for Draft Pull Request. |
Seeing some weird CI failures and trying to investigate:
|
Found the reason and solution to the build failures in openshift/cluster-network-operator#2056. Waiting for it to be merged. |
/retest-required |
Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
This reverts commit f4feb99.
Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
/test e2e-aws-upgrade |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@douglascamata: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: douglascamata, philipgough The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vendor
files should be .gitignore
'ed
What's done in the PR:
Took some extra time to...
Upgrade Prometheus used in the integration tests from a release old enough that it didn't have a build for my OS/architecture to the most recent.Verification
Verified it works by running the integration tests with Rhelemeter on debug level and a local OTEL collector receiving the traces.