Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MON-3669: Removing newlines from the jsonnet configuration for the recording rules.libsonnet #503

Merged
merged 1 commit into from Jan 29, 2024

Conversation

moadz
Copy link
Contributor

@moadz moadz commented Jan 29, 2024

The blank newlines in the recording rules forces the rhobs/config yaml parsing to insert escape chars \n into the expression, rendering it invalid promql.

This change allows us to render the yaml properly on our side.

Copy link
Contributor

@philipgough philipgough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2024
Copy link
Contributor

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/retitle MON-3669: Removing newlines from the jsonnet configuration for the recording rules.libsonnet

Copy link
Contributor

openshift-ci bot commented Jan 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: moadz, philipgough, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [philipgough,simonpasquier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot changed the title Removing newlines from the jsonnet configuration for the recording rules.libsonnet MON-3669: Removing newlines from the jsonnet configuration for the recording rules.libsonnet Jan 29, 2024
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 29, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 29, 2024

@moadz: This pull request references MON-3669 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

The blank newlines in the recording rules forces the rhobs/config yaml parsing to insert escape chars \n into the expression, rendering it invalid promql.

This change allows us to render the yaml properly on our side.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@philipgough
Copy link
Contributor

/retest

1 similar comment
@moadz
Copy link
Contributor Author

moadz commented Jan 29, 2024

/retest

Copy link
Contributor

openshift-ci bot commented Jan 29, 2024

@moadz: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 2dd35e3 into openshift:master Jan 29, 2024
10 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build telemeter-container-v4.16.0-202401300919.p0.g2dd35e3.assembly.stream for distgit telemeter.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants