New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MON-3669: Removing newlines from the jsonnet configuration for the recording rules.libsonnet #503
MON-3669: Removing newlines from the jsonnet configuration for the recording rules.libsonnet #503
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/retitle MON-3669: Removing newlines from the jsonnet configuration for the recording rules.libsonnet
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: moadz, philipgough, simonpasquier The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@moadz: This pull request references MON-3669 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/retest |
1 similar comment
/retest |
@moadz: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[ART PR BUILD NOTIFIER] This PR has been included in build telemeter-container-v4.16.0-202401300919.p0.g2dd35e3.assembly.stream for distgit telemeter. |
The blank newlines in the recording rules forces the rhobs/config yaml parsing to insert escape chars
\n
into the expression, rendering it invalid promql.This change allows us to render the yaml properly on our side.