Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MON-3708: fix test/integration.sh #509

Merged
merged 1 commit into from Feb 14, 2024
Merged

MON-3708: fix test/integration.sh #509

merged 1 commit into from Feb 14, 2024

Conversation

simonpasquier
Copy link
Contributor

No description provided.

@simonpasquier
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 14, 2024
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2024
@simonpasquier simonpasquier force-pushed the fix-integration-script branch 3 times, most recently from f20f4d4 to 88c7f3e Compare February 14, 2024 09:15
@simonpasquier simonpasquier changed the title chore: fix test/integration.sh MON-3708: fix test/integration.sh Feb 14, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 14, 2024 •
edited by openshift-ci bot

@simonpasquier: This pull request references MON-3708 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 14, 2024
@simonpasquier simonpasquier force-pushed the fix-integration-script branch 2 times, most recently from f4ff326 to ec14ab3 Compare February 14, 2024 10:35
@simonpasquier
MON-3708: fix test/integration.sh
745194b 
This change adjusts the scrape/rule intervals to reduce the test latency.
It also adds logs to show how the test progresses.

Signed-off-by: Simon Pasquier <spasquie@redhat.com>
@simonpasquier
Copy link
Contributor Author

/cc @danielmellado

merging this might also help with #497.

@simonpasquier
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 14, 2024
marioferh
marioferh reviewed Feb 14, 2024
View reviewed changes
Copy link
Contributor

@marioferh marioferh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2024
@danielmellado
Copy link
Contributor

/lgtm

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielmellado, marioferh, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [danielmellado,marioferh,simonpasquier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 14, 2024

@simonpasquier: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 450d986 into openshift:master Feb 14, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marioferh marioferh marioferh left review comments

@coleenquadros coleenquadros Awaiting requested review from coleenquadros

@slashpai slashpai Awaiting requested review from slashpai

@danielmellado danielmellado Awaiting requested review from danielmellado

Assignees

@danielmellado danielmellado

@marioferh marioferh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@simonpasquier @openshift-ci-robot @danielmellado @marioferh