Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MON-3819: Update tools go 1.21 #526

Merged
merged 1 commit into from Apr 12, 2024
Merged

MON-3819: Update tools go 1.21 #526

merged 1 commit into from Apr 12, 2024

Conversation

marioferh
Copy link
Contributor

@marioferh marioferh commented Mar 14, 2024 •
edited

Update tools to latest versions
Change test latency and duration in order to fix it

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 14, 2024
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2024
@marioferh marioferh force-pushed the update_tools_go_1_21 branch 7 times, most recently from cf2ac5b to b6a908e Compare March 15, 2024 15:04
@marioferh
Copy link
Contributor Author

/test integration

@marioferh marioferh force-pushed the update_tools_go_1_21 branch 7 times, most recently from f9b234b to e106fcb Compare March 19, 2024 08:08
@marioferh marioferh force-pushed the update_tools_go_1_21 branch 5 times, most recently from 4c28812 to 300f526 Compare April 3, 2024 07:33
@marioferh
Copy link
Contributor Author

/test integration

@marioferh marioferh force-pushed the update_tools_go_1_21 branch 3 times, most recently from c644d70 to 7f272bb Compare April 12, 2024 08:09
philipgough
philipgough approved these changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@philipgough philipgough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 12, 2024
@marioferh marioferh changed the title WIP test ci: Update tools go 1 21 Update tools go 1.21 Apr 12, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 12, 2024
@marioferh
bump tools go 1.21
2eaccdb 
update dependencies to latest versions

Signed-off-by: Mario Fernandez <mariofer@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 12, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 12, 2024

@marioferh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@philipgough
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 12, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marioferh, philipgough

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [marioferh,philipgough]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@marioferh marioferh changed the title Update tools go 1.21 MON-3819: Update tools go 1.21 Apr 12, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 12, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 12, 2024 •
edited by openshift-ci bot

@marioferh: This pull request references MON-3819 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.16.0" version, but no target version was set.

In response to this:

Update tools to latest versions
Change test latency and duration in order to fix it

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@marioferh
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 12, 2024 •
edited by openshift-ci bot

@marioferh: This pull request references MON-3819 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.16.0" version, but no target version was set.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@marioferh
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 12, 2024 •
edited by openshift-ci bot

@marioferh: This pull request references MON-3819 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.16.0" version, but no target version was set.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 89a891e into openshift:master Apr 12, 2024
9 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build telemeter-container-v4.16.0-202404121144.p0.g89a891e.assembly.stream.el9 for distgit telemeter.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipgough philipgough philipgough approved these changes

@saswatamcode saswatamcode Awaiting requested review from saswatamcode

Assignees

@philipgough philipgough

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@marioferh @philipgough @openshift-ci-robot @openshift-bot