Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/ebs: support gp3 - basic support to create gp3 volumes #12

Closed
wants to merge 2 commits into from

Conversation

mtulio
Copy link

@mtulio mtulio commented Nov 17, 2021

Add basic support to gp3 volumes on EC2. The full support was introduced on upstream release v3.22.0.

Depends/checks:

References:

Update aws-sdk-go to support gp3 volumes.

references:
- openshift#10
Depends:
- [ ] aws-sdk-go bump to v1.35.37 : openshift#11

References:
- upstream support starts on release v3.22.0: hashicorp#16517
- change default vol type on openshift installer: openshift/installer#5239
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 17, 2021
mtulio added a commit to mtulio/terraform-provider-aws that referenced this pull request Nov 18, 2021
Add basic support to gp3 volumes on EC2. The full support was introduced on upstream release v3.22.0.

This is a second option, without bump SDK to v1.35.37, as described on the PR openshift#12

References:
- upstream support starts on release v3.22.0: hashicorp#16517
- change default vol type on openshift installer: openshift/installer#5239
mtulio added a commit to mtulio/terraform-provider-aws that referenced this pull request Nov 18, 2021
Add basic support to gp3 volumes on EC2. The full support was introduced on upstream release v3.22.0.

This is a second option, without bump SDK to v1.35.37, as described on the PR openshift#12

References:
- upstream support starts on release v3.22.0: hashicorp#16517
- change default vol type on openshift installer: openshift/installer#5239
@mtulio
Copy link
Author

mtulio commented Nov 18, 2021

Closing this PR in favor of this PR that adds only the gp3 support.

The SDK bump should be added on the installer PR's, as comment here

@mtulio mtulio closed this Nov 18, 2021
@mtulio mtulio deleted the release-3.1.0-add-gp3 branch November 18, 2021 21:29
staebler pushed a commit to staebler/terraform-provider-aws that referenced this pull request Dec 15, 2021
Add basic support to gp3 volumes on EC2. The full support was introduced on upstream release v3.22.0.

This is a second option, without bump SDK to v1.35.37, as described on the PR openshift#12

References:
- upstream support starts on release v3.22.0: hashicorp#16517
- change default vol type on openshift installer: openshift/installer#5239
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant