Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1808973: azurerm terraform fixes for address_prefixes #1

Merged

Commits on Mar 13, 2020

  1. virtualnetwork: allow address_prefix to be null

    The azure subnet resource allows for multiple address prefixes using the
    address_prefixes argument. The virtual network resource allows inline subnets,
    but does not currently support this argument. When the address_prefixes argument
    is used, address_prefix will be null when terraform refreshes its state causing
    terraform to panic. This code updates the virtual network resource to allow
    address_prefixes to be used and for address_prefix to be null.
    
    Tests have been added to test the multiple prefixes. The magic number in the
    new tests is the same magic number used in the other VNet tests. I'm not 100%
    clear on this number, but it appears to be a known ID. It's origin is
    documented (not very well) here:
    
    hashicorp#1913
    
    This fix addresses the following bugs:
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1805251
    https://bugzilla.redhat.com/show_bug.cgi?id=1808973
    https://bugzilla.redhat.com/show_bug.cgi?id=1805936
    https://bugzilla.redhat.com/show_bug.cgi?id=1808969
    jhixson74 committed Mar 13, 2020
    Configuration menu
    Copy the full SHA
    8f31940 View commit details
    Browse the repository at this point in the history
  2. loadbalancer: don't assume IPv4 IP address on load balancer

    The azure load balancer resource's frontend_ip_configuration argument assumes
    the IP address is only going to be IPv4. This removes that restriction to be
    in line with the rest of the terraform code that does not have that validation.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1808973
    jhixson74 committed Mar 13, 2020
    Configuration menu
    Copy the full SHA
    aacd63a View commit details
    Browse the repository at this point in the history