OCPBUGS-19406: Fix rh-manifest.txt generation

[raptorsun]

This PR should fix the problem that rh-manifest.txt is generated empty in the PR #118

[openshift-ci-robot]

@raptorsun: This pull request references Jira Issue OCPBUGS-19406, which is invalid:

• expected the bug to target the "4.15.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This PR should fix the problem that rh-manifest.txt is generated empty in the PR #118

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[machine424]

Could you explain why using lock file and npm (instead of yarn) solved the issue?

[raptorsun]

because yarn complains about missing lock file and not able to produce a list of dependencies. but the package-lock.json file is there.

➜  thanos git:(master) ./scripts/rh-manifest.sh
{"type":"error","data":"No lockfile in this directory. Run `yarn install` to generate one."}

[machine424]

Ok, thanks, understand better now.

[machine424]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: machine424, raptorsun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [machine424,raptorsun]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[raptorsun]

/jira refresh

[openshift-ci-robot]

@raptorsun: This pull request references Jira Issue OCPBUGS-19406, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.15.0) matches configured target version for branch (4.15.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @juzhao

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD a91c734 and 2 for PR HEAD e7c77b7 in total

[openshift-ci]

@raptorsun: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@raptorsun: Jira Issue OCPBUGS-19406: All pull requests linked via external trackers have merged:

• openshift/thanos#120

Jira Issue OCPBUGS-19406 has been moved to the MODIFIED state.

In response to this:

This PR should fix the problem that rh-manifest.txt is generated empty in the PR #118

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.