Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1994156: dockerignore: remove vendor from ignored list #70

Merged
merged 2 commits into from Aug 18, 2021

Conversation

philipgough
Copy link

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Backport of required commit in #59

@openshift-ci
Copy link

openshift-ci bot commented Aug 17, 2021

@philipgough: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

.dockerignore: remove vendor from ignored list

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@philipgough philipgough changed the title .dockerignore: remove vendor from ignored list Bug 1994156: dockerignore: remove vendor from ignored list Aug 17, 2021
@openshift-ci openshift-ci bot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Aug 17, 2021
@openshift-ci
Copy link

openshift-ci bot commented Aug 17, 2021

@philipgough: This pull request references Bugzilla bug 1994156, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.z) matches configured target release for branch (4.8.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1994155 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1994155 targets the "4.9.0" release, which is one of the valid target releases: 4.9.0
  • bug has dependents

Requesting review from QA contact:
/cc @juzhao

In response to this:

Bug 1994156: dockerignore: remove vendor from ignored list

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yselkowitz
Copy link

/lgtm
/assign @paulfantom

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 17, 2021
@simonpasquier
Copy link

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 17, 2021
@paulfantom
Copy link

/lgtm
/retest

@openshift-ci
Copy link

openshift-ci bot commented Aug 17, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: paulfantom, PhilipGough, simonpasquier, yselkowitz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [paulfantom,simonpasquier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@simonpasquier
Copy link

/retest

1 similar comment
@simonpasquier
Copy link

/retest

@deads2k deads2k added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Aug 18, 2021
@openshift-merge-robot openshift-merge-robot merged commit f7c1227 into openshift:release-4.8 Aug 18, 2021
@openshift-ci
Copy link

openshift-ci bot commented Aug 18, 2021

@philipgough: All pull requests linked via external trackers have merged:

Bugzilla bug 1994156 has been moved to the MODIFIED state.

In response to this:

Bug 1994156: dockerignore: remove vendor from ignored list

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@deads2k
Copy link

deads2k commented Aug 18, 2021

patch manager: urgent BZ, used for building

@philipgough philipgough deleted the bz-1994156 branch August 19, 2021 08:15
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-thanos-container-v4.8.0-202311261141.p0.gf7c1227.assembly.stream for distgit thanos.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants