OADP-645: VSR performance improvements

[eemcmullan]

image: quay.io/emcmulla/csi-plugin:perf

To test:

• take backup using data mover of an app with multiple PVCs, such as robot-shop
• delete app and VSCs after backup completes
• in DPA, override CSI image with quay.io/emcmulla/csi-plugin:perf and Velero image with quay.io/emcmulla/velero:perf
• create restore with data mover
• in Velero logs, you should notice waiting for all VSRs to complete simultaneously

[weshayutin]

@eemcmullan is it possible to post some testing instructions in the comments here. I'd like to run through taking a volume snapshot and restore w/ and w/o this patch.

Thank you in advance!

[eemcmullan]

@weshayutin updated description with instructions

[kaovilai]

Should this be hardcoded to ebs? What about other providers?

[eemcmullan]

This driver isn't actually used for anything since this VSClass is only needed for blocking VSR. It is only there because creating a VSClass will fail without this field. However I need to look into whether or not this will error on other drivers not available, such as Azure.

[kaovilai]

A safer one IMO would be to copy an existing voluemsnapshotclass or get driver name from existing storageclass, change the name, and proceed. This would be a more generic way to achieve what you want across providers.

[shubham-pampattiwar]

Tested the changes on latest volsync main branch, worked for me ! Just a couple of nits ! Thank you @eemcmullan

[kaovilai]

This works on 4.11? If yes then we're good to go.

[eemcmullan]

tested with success on 4.11

[eemcmullan]

/cherry-pick oadp-1.1

[openshift-cherrypick-robot]

@eemcmullan: #37 failed to apply on top of branch "oadp-1.1":

Applying: VSR perf improvements
Using index info to reconstruct a base tree...
M	internal/util/labels_annotations.go
M	internal/util/util.go
Falling back to patching base and 3-way merge...
Auto-merging internal/util/util.go
CONFLICT (content): Merge conflict in internal/util/util.go
Auto-merging internal/util/labels_annotations.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 VSR perf improvements
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick oadp-1.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.