Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OADP-612: Check VSB status conditions for failure #40

Merged
merged 6 commits into from Sep 19, 2022
Merged

OADP-612: Check VSB status conditions for failure #40

merged 6 commits into from Sep 19, 2022

Conversation

eemcmullan
Copy link

@eemcmullan eemcmullan commented Aug 16, 2022 •
edited

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 16, 2022
shubham-pampattiwar
shubham-pampattiwar requested changes Aug 16, 2022
View reviewed changes
internal/backup/volumesnapshotbackup_action.go Outdated Show resolved Hide resolved
internal/util/util.go Outdated Show resolved Hide resolved
@eemcmullan eemcmullan removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 17, 2022
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 17, 2022
@eemcmullan eemcmullan mentioned this pull request Aug 17, 2022
Closed
@eemcmullan eemcmullan marked this pull request as ready for review August 17, 2022 17:41
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 17, 2022
weshayutin
weshayutin reviewed Sep 2, 2022
View reviewed changes
Copy link

@weshayutin weshayutin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but too much of a newb to approve w/o testing locally.

@eemcmullan eemcmullan merged commit 963ea47 into openshift:main Sep 19, 2022
@eemcmullan
Copy link
Author

/cherry-pick oadp-1.1

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 19, 2022
Merged
@openshift-cherrypick-robot
Copy link

@eemcmullan: new pull request created: #44

In response to this:

/cherry-pick oadp-1.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eemcmullan eemcmullan deleted the vsm-err branch October 18, 2022 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weshayutin weshayutin weshayutin left review comments

@kaovilai kaovilai kaovilai approved these changes

@shubham-pampattiwar shubham-pampattiwar shubham-pampattiwar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@eemcmullan @openshift-cherrypick-robot @weshayutin @kaovilai @shubham-pampattiwar