Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use numeric user for velero-restic-restore-helper #130

Conversation

sseago
Copy link

@sseago sseago commented Oct 25, 2021

Use numeric user for velero-restic-restore-helper

Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com>

Cherry-picked from cabd8e9

dymurray and others added 13 commits September 22, 2021 12:29
(cherry picked from commit 00c1eb6)

version bump; update restic branch/build;rebase log 1.6.0-rc.1

(cherry picked from commit 05bae5e)

Fixed version tag for velero 1.6.0 (not rc1)

(cherry picked from commit 8022187)

Point back to konveyor-dev for restic

(cherry picked from commit 8436504)

Don't use builder from docker.io

(cherry picked from commit 1f9a6f4)
(cherry picked from commit 2564a14)

Default insecureSkipTLSVerify to false if ParseBool fails

(cherry picked from commit 9f1b3b9)

Respect insecureSkipTLSVerify in getSnapshotSize

(cherry picked from commit b74c10d)
(cherry picked from commit f1160a8)
Added support for restic volume checksum verification.
This adds another pod annotation ('backup.velero.io/verify-volumes')
which is used to identify which volumes on the pod should get the
'--verify' flag passed to restic when restoring.

Stdout and stderr are logged to the restic pod logs. The PodVolumeRestore
CRD has three new status fields: Errors, VerifyErrors, and ResticPod,
which contain the number of total errors reported, the number of verify
errors reported, and the name of the restic pod that ran the restore
(to allow for the user to look in the pod logs for more detailed output).

The Restore CRD has two new Status fields: PodVolumeRestoreErrors
and PodVolumeRestoreVerifyErrors, which contain a slice of ObjectReferences
listing which PodVolumeRestores contained errors or verify errors.

There is not yet support built into restore describe to see the restore fields
via the velero client. Also, the restic daemonset will need to have an env
variable set for POD_NAME.

(cherry picked from commit da2df66)
(cherry picked from commit 5a05c6b)
Signed-off-by: Scott Seago <sseago@redhat.com>
Signed-off-by: Scott Seago <sseago@redhat.com>
(cherry picked from commit b845d23)
(cherry picked from commit ccb545f)

Update PR-BZ automation mapping (openshift#84)

(cherry picked from commit aa2b019)

Update PR-BZ automation (openshift#92)

Co-authored-by: Rayford Johnson <rjohnson@redhat.com>
(cherry picked from commit ecc563f)

Add publish workflow (openshift#108)

(cherry picked from commit f87b779)
Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com>
@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 25, 2022
@openshift-ci
Copy link

openshift-ci bot commented Apr 25, 2022

@sseago: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sseago
Copy link
Author

sseago commented Apr 25, 2022

/remove-lifecycle stale

@openshift-ci openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 25, 2022
@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 24, 2022
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 24, 2022
@weshayutin
Copy link

@sseago can this be closed?

@sseago
Copy link
Author

sseago commented Sep 2, 2022

@weshayutin Looks like it can, yes. The current codebase has this change already, not only on the dev branch but also in the oadp release branches.

@sseago sseago closed this Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants