OADP-605: Fix edge case for already exists resources #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaovilai
approved these changes
Aug 11, 2022
kaovilai
approved these changes
Aug 11, 2022
galt-tr
approved these changes
Aug 11, 2022
dymurray
approved these changes
Aug 11, 2022
sseago
requested changes
Aug 11, 2022
sseago
reviewed
Aug 11, 2022
sseago
requested changes
Aug 11, 2022
sseago
approved these changes
Aug 11, 2022
sseago
approved these changes
Aug 11, 2022
kaovilai
requested changes
Aug 11, 2022
| if isAlreadyExistsError || objectExists { | ||
| // do a get call if we did not run this previously i.e. | ||
| // we've only run this for errors other than isAlreadyExistError | ||
| if fromCluster == nil { |
There was a problem hiding this comment.
If objectexists == true then fromcluster wouldn't be nil.
No need to call get here.
There was a problem hiding this comment.
We need a get call for the AlreadyExistError case, the get call you are referring to is done if error from create is not AlreadyExistsError
kaovilai
approved these changes
Aug 11, 2022
|
/cherry-pick konveyor-1.9.1 |
|
@shubham-pampattiwar: new pull request created: #187 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.