Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OADP-1833: Cleanup completed VSBs in backup finalize phase #271

Merged
merged 1 commit into from May 18, 2023
Merged

OADP-1833: Cleanup completed VSBs in backup finalize phase #271

merged 1 commit into from May 18, 2023

Conversation

shubham-pampattiwar
Copy link
Member

No description provided.

@shubham-pampattiwar
OADP-1833: Cleanup completed VSBs in backup finalize phase
ae5e2e3 
fix unit test

revert to using controller-gen 0.7

update vsb failed check condition

(cherry picked from commit abd4ed0)
@shubham-pampattiwar shubham-pampattiwar self-assigned this May 17, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 17, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 17, 2023 •
edited by openshift-ci bot

@shubham-pampattiwar: This pull request references OADP-1833 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@shubham-pampattiwar shubham-pampattiwar mentioned this pull request May 17, 2023
Closed
@openshift-ci
Copy link

openshift-ci bot commented May 17, 2023

@shubham-pampattiwar: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 17, 2023
@openshift-ci
Copy link

openshift-ci bot commented May 17, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shubham-pampattiwar, sseago

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@shubham-pampattiwar shubham-pampattiwar merged commit 34ab2a0 into openshift:oadp-1.2 May 18, 2023
3 of 4 checks passed
@kaovilai kaovilai mentioned this pull request Jul 11, 2023
Closed
3 tasks
sseago pushed a commit that referenced this pull request Aug 10, 2023
@shubham-pampattiwar @sseago
OADP-1833: Cleanup completed VSBs in backup finalize phase (#271)
3a36c90 
fix unit test

revert to using controller-gen 0.7

update vsb failed check condition

(cherry picked from commit abd4ed0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sseago sseago sseago approved these changes

Assignees

@sseago sseago

@shubham-pampattiwar shubham-pampattiwar

Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shubham-pampattiwar @openshift-ci-robot @sseago