New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPNODE-1707: Updates for 4.14 #146
Conversation
@joelsmith: This pull request references OCPNODE-1707 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Update hack/update-vendor.sh script to also handle k8s dep versioning Updates for 4.14 * Update deps * edit (update to 4.14/0.27.3) and run hack/update-vendor.sh * go get k8s.io/kube-openapi@54b630e78af56d3a939d3e1d1f0d4d18f3093ace && go mod tidy && go mod vendor * Update code and build to match updated deps * Update to go 1.20 (go.mod, Dockerfile, images/ci/Dockerfile) * Rev version from 4.13 -> 4.14: sed -i 's/4\.13/4\.14/g' $(git grep -l 4\.13 manifests/) images/ci/bundle.Dockerfile hack/manifest-diff-upstream.sh hack/e2e.sh Makefile * Verify that Dockerfile.rhel7 & .ci-operator.yaml are up to date (they are. Thanks, ART team!) kube-openapi pin required as @latest was incompatible with k8s.io/*@v0.27.3
/retest |
@joelsmith: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: joelsmith, rphillips The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[ART PR BUILD NOTIFIER] This PR has been included in build ose-vertical-pod-autoscaler-operator-container-v4.14.0-202311211133.p0.geae798e.assembly.stream for distgit vertical-pod-autoscaler-operator. |
Update hack/update-vendor.sh script to also handle k8s dep versioning
Updates for 4.14
sed -i 's/4.13/4.14/g' $(git grep -l 4.13 manifests/) images/ci/bundle.Dockerfile hack/manifest-diff-upstream.sh hack/e2e.sh Makefile
kube-openapi pin required as @latest was incompatible with k8s.io/*@v0.27.3