Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPNODE-1707: Updates for 4.14 #146

Merged
merged 1 commit into from Jul 12, 2023

Conversation

joelsmith
Copy link
Contributor

Update hack/update-vendor.sh script to also handle k8s dep versioning

Updates for 4.14

  • Update deps
  • edit (update to 4.14/0.27.3) and run hack/update-vendor.sh
  • go get k8s.io/kube-openapi@54b630e78af56d3a939d3e1d1f0d4d18f3093ace && go mod tidy && go mod vendor
  • Update code and build to match updated deps
  • Update to go 1.20 (go.mod, Dockerfile, images/ci/Dockerfile)
  • Rev version from 4.13 -> 4.14:
    sed -i 's/4.13/4.14/g' $(git grep -l 4.13 manifests/) images/ci/bundle.Dockerfile hack/manifest-diff-upstream.sh hack/e2e.sh Makefile
  • Verify that Dockerfile.rhel7 & .ci-operator.yaml are up to date (they are. Thanks, ART team!)

kube-openapi pin required as @latest was incompatible with k8s.io/*@v0.27.3

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 12, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 12, 2023

@joelsmith: This pull request references OCPNODE-1707 which is a valid jira issue.

In response to this:

Update hack/update-vendor.sh script to also handle k8s dep versioning

Updates for 4.14

  • Update deps
  • edit (update to 4.14/0.27.3) and run hack/update-vendor.sh
  • go get k8s.io/kube-openapi@54b630e78af56d3a939d3e1d1f0d4d18f3093ace && go mod tidy && go mod vendor
  • Update code and build to match updated deps
  • Update to go 1.20 (go.mod, Dockerfile, images/ci/Dockerfile)
  • Rev version from 4.13 -> 4.14:
    sed -i 's/4.13/4.14/g' $(git grep -l 4.13 manifests/) images/ci/bundle.Dockerfile hack/manifest-diff-upstream.sh hack/e2e.sh Makefile
  • Verify that Dockerfile.rhel7 & .ci-operator.yaml are up to date (they are. Thanks, ART team!)

kube-openapi pin required as @latest was incompatible with k8s.io/*@v0.27.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 12, 2023
Update hack/update-vendor.sh script to also handle k8s dep versioning

Updates for 4.14
* Update deps
* edit (update to 4.14/0.27.3) and run hack/update-vendor.sh
* go get k8s.io/kube-openapi@54b630e78af56d3a939d3e1d1f0d4d18f3093ace && go mod tidy && go mod vendor
* Update code and build to match updated deps
* Update to go 1.20 (go.mod, Dockerfile, images/ci/Dockerfile)
* Rev version from 4.13 -> 4.14:
    sed -i 's/4\.13/4\.14/g' $(git grep -l 4\.13 manifests/) images/ci/bundle.Dockerfile hack/manifest-diff-upstream.sh hack/e2e.sh Makefile
* Verify that Dockerfile.rhel7 & .ci-operator.yaml are up to date (they are. Thanks, ART team!)

kube-openapi pin required as @latest was incompatible with k8s.io/*@v0.27.3
@joelsmith
Copy link
Contributor Author

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 12, 2023

@joelsmith: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rphillips
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 12, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelsmith, rphillips

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [joelsmith,rphillips]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit eae798e into openshift:master Jul 12, 2023
9 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-vertical-pod-autoscaler-operator-container-v4.14.0-202311211133.p0.geae798e.assembly.stream for distgit vertical-pod-autoscaler-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants