New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1950210: Update CRD API version to match upstream and cleanup for yamllint #89
Conversation
This PR has two purposes. In addition to updating the CRD from the deprecated v1beta1 version to v1, I expect this PR to fail the new Edit: it did fail the test as hoped. Updated commit pushed to bring the two versions into sync. |
/retest |
@joelsmith: This pull request references Bugzilla bug 1950210, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (weinliu@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@wangchen615 could you please review? I used this to update the upstream object CRDs: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: joelsmith, wangchen615 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@joelsmith: All pull requests linked via external trackers have merged: Bugzilla bug 1950210 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The CRD API version v1beta1 is being deprecated, so we must update all CRDs to v1.