STOR-1304: Restart controller pods if metrics serving cert or webhook secret changed

[mpatlasov]

Adding WithSecretHashAnnotationHook() for vmware-vsphere-csi-driver-controller-metrics-serving-cert ensures that new annotation is published in vmware-vsphere-csi-driver-controller deployment. This, in turn, leads to controller pods restart.

Similarly, adding WithSecretHashAnnotationHook() for vmware-vsphere-csi-driver-webhook-secret ensures that new annotation is published in vmware-vsphere-csi-driver-webhook deployment. This, in turn, leads to webhook pods restart.

[openshift-ci-robot]

@mpatlasov: This pull request references STOR-1304 which is a valid jira issue.

In response to this:

Adding WithSecretHashAnnotationHook() for vmware-vsphere-csi-driver-controller-metrics-serving-cert ensures that new annotation is published in vmware-vsphere-csi-driver-controller deployment. This, in turn, leads to controller pods restart.

Similarly, adding WithSecretHashAnnotationHook() for vmware-vsphere-csi-driver-webhook-secret ensures that new annotation is published in vmware-vsphere-csi-driver-webhook deployment. This, in turn, leads to webhook pods restart.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mpatlasov]

/assign @jsafrane
/label docs-approved
/label px-approved

[mpatlasov]

/retest

[mpatlasov]

/retest

[jsafrane]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, mpatlasov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jsafrane]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Phaow]

Pre verifiy passed with the pre merged build 4.13.0-0.ci.test-2023-05-22-055536-ci-ln-84lnz2t-latest

# After the metrics-serving-cert secret changed, driver controller restarted

$ oc get po -l app=vmware-vsphere-csi-driver-controller
NAME                                                    READY   STATUS        RESTARTS   AGE
vmware-vsphere-csi-driver-controller-5b946cdb66-qmzns   0/13    Pending       0          15s
vmware-vsphere-csi-driver-controller-787dcbb746-ndb86   13/13   Terminating   0          16s
vmware-vsphere-csi-driver-controller-86bffdd864-d4hbv   13/13   Running       0          98m
vmware-vsphere-csi-driver-controller-86bffdd864-mqmtk   13/13   Terminating   0          98m

$ oc get po -l app=vmware-vsphere-csi-driver-webhook -w
NAME                                                 READY   STATUS        RESTARTS   AGE
vmware-vsphere-csi-driver-webhook-6b6cb7799d-89d4z   1/1     Terminating   0          36m
vmware-vsphere-csi-driver-webhook-6b6cb7799d-c7bfd   1/1     Terminating   0          36m
vmware-vsphere-csi-driver-webhook-74c4856bfc-tzjdq   1/1     Running       0          23s
vmware-vsphere-csi-driver-webhook-74c4856bfc-xsjf8   1/1     Running       0          23s
vmware-vsphere-csi-driver-webhook-89b7b994-j4rdj     1/1     Terminating   0          25s
vmware-vsphere-csi-driver-webhook-89b7b994-j9lvv     1/1     Terminating   0          25s
vmware-vsphere-csi-driver-webhook-6b6cb7799d-c7bfd   0/1     Terminating   0          36m
vmware-vsphere-csi-driver-webhook-6b6cb7799d-c7bfd   0/1     Terminating   0          36m
vmware-vsphere-csi-driver-webhook-6b6cb7799d-c7bfd   0/1     Terminating   0          36m
vmware-vsphere-csi-driver-webhook-89b7b994-j9lvv     0/1     Terminating   0          34s
vmware-vsphere-csi-driver-webhook-89b7b994-j9lvv     0/1     Terminating   0          34s
vmware-vsphere-csi-driver-webhook-89b7b994-j9lvv     0/1     Terminating   0          34s
vmware-vsphere-csi-driver-webhook-89b7b994-j4rdj     0/1     Terminating   0          34s
vmware-vsphere-csi-driver-webhook-89b7b994-j4rdj     0/1     Terminating   0          34s
vmware-vsphere-csi-driver-webhook-89b7b994-j4rdj     0/1     Terminating   0          34s
vmware-vsphere-csi-driver-webhook-6b6cb7799d-89d4z   0/1     Terminating   0          37m
vmware-vsphere-csi-driver-webhook-6b6cb7799d-89d4z   0/1     Terminating   0          37m
vmware-vsphere-csi-driver-webhook-6b6cb7799d-89d4z   0/1     Terminating   0          37m

[Phaow]

/label qe-approved

[openshift-ci]

@mpatlasov: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.