Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STOR-1578: Revert "Merge pull request #195 from gnufied/revert-192-enable-new-fe… #212

Merged

Conversation

gnufied
Copy link
Member

@gnufied gnufied commented Jan 16, 2024

…atures-csi-driver"

This reverts commit b17da9c, reversing changes made to 330d290.

Fixes https://issues.redhat.com/browse/STOR-1578

…le-new-features-csi-driver"

This reverts commit b17da9c, reversing
changes made to 330d290.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 16, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 16, 2024

@gnufied: This pull request references STOR-1578 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

…atures-csi-driver"

This reverts commit b17da9c, reversing changes made to 330d290.

Fixes https://issues.redhat.com/browse/STOR-1578

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Jan 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2024
@gnufied
Copy link
Member Author

gnufied commented Jan 16, 2024

I am bringing this first, because without this, bringing the vsphere driver rebase will cause driver to crash loop.

@gnufied
Copy link
Member Author

gnufied commented Jan 17, 2024

/retest

1 similar comment
@Phaow
Copy link
Contributor

Phaow commented Jan 22, 2024

/retest

@dobsonj
Copy link
Member

dobsonj commented Jan 22, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2024
@gnufied
Copy link
Member Author

gnufied commented Jan 23, 2024

/override ci/prow/e2e-vsphere-ovn-upgrade

Copy link
Contributor

openshift-ci bot commented Jan 23, 2024

@gnufied: Overrode contexts on behalf of gnufied: ci/prow/e2e-vsphere-ovn-upgrade

In response to this:

/override ci/prow/e2e-vsphere-ovn-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gnufied
Copy link
Member Author

gnufied commented Jan 23, 2024

/label docs-approved
/label px-approved

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Jan 23, 2024
@duanwei33
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jan 24, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 24, 2024

@gnufied: This pull request references STOR-1578 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

…atures-csi-driver"

This reverts commit b17da9c, reversing changes made to 330d290.

Fixes https://issues.redhat.com/browse/STOR-1578

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Jan 24, 2024

@gnufied: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit ffd5ab4 into openshift:master Jan 24, 2024
10 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-vmware-vsphere-csi-driver-operator-container-v4.16.0-202401242108.p0.gffd5ab4.assembly.stream for distgit ose-vmware-vsphere-csi-driver-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants