Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-27242: fix or ignore snyk errors for ocp storage repos #213

Merged
merged 1 commit into from Jan 19, 2024

Conversation

dobsonj
Copy link
Member

@dobsonj dobsonj commented Jan 16, 2024

Ignore these two errors. The simulator is only used from unit test code and does not contain real credentials.

 ✗ [Low] Use of Hardcoded Credentials
   ID: 1bbb6426-7781-4fd7-b74a-64bc739ffc49 
   Path: pkg/operator/testlib/vcsim_framework.go, line 83 
   Info: Do not hardcode credentials in code. Found hardcoded credential used in Username.
 ✗ [Medium] Use of Hardcoded Credentials
   ID: 6420cae8-510f-4c8d-8051-d22a2c61529c 
   Path: pkg/operator/testlib/vcsim_framework.go, line 84 
   Info: Do not hardcode passwords in code. Found hardcoded saved in Password.

from https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_release/47618/rehearse-47618-pull-ci-openshift-vmware-vsphere-csi-driver-operator-master-security/1745954200828776448

/cc @openshift/storage

@openshift-ci-robot openshift-ci-robot added the jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. label Jan 16, 2024
@openshift-ci openshift-ci bot requested a review from a team January 16, 2024 21:53
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 16, 2024
@openshift-ci-robot
Copy link
Contributor

@dobsonj: This pull request references Jira Issue OCPBUGS-27242, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Ignore these two errors. The simulator is only used from unit test code and does not contain real credentials.

✗ [Low] Use of Hardcoded Credentials
  ID: 1bbb6426-7781-4fd7-b74a-64bc739ffc49 
  Path: pkg/operator/testlib/vcsim_framework.go, line 83 
  Info: Do not hardcode credentials in code. Found hardcoded credential used in Username.
✗ [Medium] Use of Hardcoded Credentials
  ID: 6420cae8-510f-4c8d-8051-d22a2c61529c 
  Path: pkg/operator/testlib/vcsim_framework.go, line 84 
  Info: Do not hardcode passwords in code. Found hardcoded saved in Password.

from https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_release/47618/rehearse-47618-pull-ci-openshift-vmware-vsphere-csi-driver-operator-master-security/1745954200828776448

/cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Jan 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dobsonj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2024
@dobsonj
Copy link
Member Author

dobsonj commented Jan 16, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 16, 2024
@openshift-ci-robot
Copy link
Contributor

@dobsonj: This pull request references Jira Issue OCPBUGS-27242, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jsafrane
Copy link
Contributor

/lgtm
/retest

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD a528a06 and 2 for PR HEAD 3757f76 in total

@dobsonj
Copy link
Member Author

dobsonj commented Jan 19, 2024

/retest-required

@dobsonj
Copy link
Member Author

dobsonj commented Jan 19, 2024

/override ci/prow/e2e-vsphere-ovn-upgrade

Copy link
Contributor

openshift-ci bot commented Jan 19, 2024

@dobsonj: Overrode contexts on behalf of dobsonj: ci/prow/e2e-vsphere-ovn-upgrade

In response to this:

/override ci/prow/e2e-vsphere-ovn-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dobsonj
Copy link
Member Author

dobsonj commented Jan 19, 2024

/override ci/prow/e2e-vsphere-ovn-upgrade
/override ci/prow/e2e-vsphere

Copy link
Contributor

openshift-ci bot commented Jan 19, 2024

@dobsonj: Overrode contexts on behalf of dobsonj: ci/prow/e2e-vsphere, ci/prow/e2e-vsphere-ovn-upgrade

In response to this:

/override ci/prow/e2e-vsphere-ovn-upgrade
/override ci/prow/e2e-vsphere

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

openshift-ci bot commented Jan 19, 2024

@dobsonj: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-zones 3757f76 link false /test e2e-vsphere-zones

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 5973db6 into openshift:master Jan 19, 2024
9 of 10 checks passed
@openshift-ci-robot
Copy link
Contributor

@dobsonj: Jira Issue OCPBUGS-27242: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-27242 has been moved to the MODIFIED state.

In response to this:

Ignore these two errors. The simulator is only used from unit test code and does not contain real credentials.

✗ [Low] Use of Hardcoded Credentials
  ID: 1bbb6426-7781-4fd7-b74a-64bc739ffc49 
  Path: pkg/operator/testlib/vcsim_framework.go, line 83 
  Info: Do not hardcode credentials in code. Found hardcoded credential used in Username.
✗ [Medium] Use of Hardcoded Credentials
  ID: 6420cae8-510f-4c8d-8051-d22a2c61529c 
  Path: pkg/operator/testlib/vcsim_framework.go, line 84 
  Info: Do not hardcode passwords in code. Found hardcoded saved in Password.

from https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_release/47618/rehearse-47618-pull-ci-openshift-vmware-vsphere-csi-driver-operator-master-security/1745954200828776448

/cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.16.0-0.nightly-2024-01-21-092529

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants