Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1954671: disable volume expansion support in vsphere csi driver #24

Merged
merged 1 commit into from May 14, 2021
Merged

Bug 1954671: disable volume expansion support in vsphere csi driver #24

merged 1 commit into from May 14, 2021

Conversation

dobsonj
Copy link
Member

@dobsonj dobsonj commented May 10, 2021

No description provided.

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels May 10, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 10, 2021

@dobsonj: This pull request references Bugzilla bug 1954671, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (piqin@redhat.com), skipping review request.

In response to this:

Bug 1954671: disable volume expansion support in vsphere csi driver

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 10, 2021

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot requested review from bertinatto and gnufied May 10, 2021 22:40
@dobsonj
Copy link
Member Author

dobsonj commented May 10, 2021

/test all

bertinatto
bertinatto reviewed May 11, 2021
View reviewed changes
assets/storageclass.yaml
@@ -6,4 +6,4 @@ provisioner: csi.vsphere.vmware.com
parameters:
datastoreurl: "${DATASTORE_URL}"
volumeBindingMode: WaitForFirstConsumer
allowVolumeExpansion: true
allowVolumeExpansion: false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be interesting to add a comment stating why this is currently disabled with a link to the ticket/issue that needs to be fixed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, we need to run make update to update the bindata file and include that in this PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may be we need a verify job to catch failure to run make update somewhere

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bertinatto , updated.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see those limitations were mentioned in the doc like only vSan support it?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually resize only support block volume, not vSAN, I think.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, so I think at some point this document was changed. But I could confirm with vmware engineers again. In any case - volume expansion is still beta and hence it makes sense for us to keep it disabled until we could test and validate it.

@dobsonj
Copy link
Member Author

dobsonj commented May 11, 2021

/test all

1 similar comment
@dobsonj
Copy link
Member Author

dobsonj commented May 11, 2021

/test all

@bertinatto
Copy link
Member

/test e2e-vsphere-csi

@dobsonj
Copy link
Member Author

dobsonj commented May 12, 2021

Verified that after deploying this change, resize fails with an appropriate error message:

$ oc patch pvc claim1 -p '{"spec": {"resources": {"requests": {"storage":"2Gi"} } } }'
Error from server (Forbidden): persistentvolumeclaims "claim1" is forbidden: only dynamically provisioned pvc can be resized and the storageclass that provisions the pvc must support resize

@dobsonj dobsonj marked this pull request as ready for review May 12, 2021 20:23
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 12, 2021
@dobsonj
Copy link
Member Author

dobsonj commented May 12, 2021

/retest

3 similar comments
@dobsonj
Copy link
Member Author

dobsonj commented May 12, 2021

/retest

@dobsonj
Copy link
Member Author

dobsonj commented May 13, 2021

/retest

@dobsonj
Copy link
Member Author

dobsonj commented May 13, 2021

/retest

@dobsonj dobsonj force-pushed the bug1954671-disable-vol-expansion branch from 814b82d to cd7dfdc Compare May 13, 2021 16:23
@gnufied
Copy link
Member

gnufied commented May 13, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2021
@dobsonj
Copy link
Member Author

dobsonj commented May 13, 2021

/retest

@gnufied
Copy link
Member

gnufied commented May 13, 2021

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 13, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dobsonj, gnufied

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2021
@dobsonj
Copy link
Member Author

dobsonj commented May 13, 2021

/retest

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit edbdd69 into openshift:master May 14, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 14, 2021

@dobsonj: All pull requests linked via external trackers have merged:

Bugzilla bug 1954671 has been moved to the MODIFIED state.

In response to this:

Bug 1954671: disable volume expansion support in vsphere csi driver

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dobsonj dobsonj deleted the bug1954671-disable-vol-expansion branch May 14, 2021 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertinatto bertinatto bertinatto left review comments

@jingxu97 jingxu97 jingxu97 left review comments

@gnufied gnufied Awaiting requested review from gnufied

Assignees

@gnufied gnufied

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dobsonj @bertinatto @gnufied @openshift-bot @jingxu97 @openshift-merge-robot