[release-4.8] Bug 2021620: Close connection to vCenter API

[rvanderp3]

The intention of this PR is to backport a fix to close stale connections which was implemented in #50 and #47 to 4.8. There are structural differences in pkg/operator/storageclasscontroller/vmware.go which prevent a cherrypick and as such this PR was created. As is done in prior PRs on this issue, logout is called on the vim25.Client instance which results in the session being logged out and idle connections being closed.

[openshift-ci]

@rvanderp3: This pull request references Bugzilla bug 2021620, which is invalid:

• expected dependent Bugzilla bug 2009859 to target a release in 4.9.0, 4.9.z, but it targets "4.10.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.8] Bug 2021620: Close connection to vCenter API

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rvanderp3]

/bugzilla refresh

[openshift-ci]

@rvanderp3: This pull request references Bugzilla bug 2021620, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.8.z) matches configured target release for branch (4.8.z)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
• dependent bug Bugzilla bug 2018496 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
• dependent Bugzilla bug 2018496 targets the "4.9.z" release, which is one of the valid target releases: 4.9.0, 4.9.z
• bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (wduan@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jsafrane]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, rvanderp3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jsafrane]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jsafrane]

/label backport-risk-assessed

[jsafrane]

/cc @chao007 @duanwei33
for cherry-pick-approved label

[duanwei33]

/label cherry-pick-approved

[openshift-ci]

@rvanderp3: All pull requests linked via external trackers have merged:

• openshift/vmware-vsphere-csi-driver-operator#51

Bugzilla bug 2021620 has been moved to the MODIFIED state.

In response to this:

[release-4.8] Bug 2021620: Close connection to vCenter API

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-vmware-vsphere-csi-driver-operator-container-v4.8.0-202311261141.p0.g18cd987.assembly.stream for distgit ose-vmware-vsphere-csi-driver-operator.
All builds following this will include this PR.