OCPBUGS-14829: Warn usernames without domain name #121
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@gnufied: This pull request references Jira Issue OCPBUGS-14829, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
jira/valid-bug
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gnufied The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
| if strings.Index(username, "@") < 0 { | ||
| klog.Warningf("vCenter username for %s is without domain, please consider using username with full domain name", cfg.Workspace.VCenterIP) | ||
| } | ||
|
|
There was a problem hiding this comment.
@jcpowermac points out that, it could also be DOMAIN/username and that will be a valid combo. Need to check and update.
There was a problem hiding this comment.
Using / as separator doesn't work for me. It is a warning anyways, so lets merge it. We don't have an active directory setup where we could test this differently.
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
openshift-ci
bot
added
the
lifecycle/stale
|
/retest-required |
|
@gnufied: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@gnufied: Jira Issue OCPBUGS-14829: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-14829 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.14 |
|
@gnufied: new pull request created: #134 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes https://issues.redhat.com/browse/OCPBUGS-14829
We could emit a metric here as well, and create alerts but I am worried about customers then complaining about noisy alerts.