Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STOR-1574: Bump library-go #152

Merged
merged 1 commit into from Jan 19, 2024
Merged

STOR-1574: Bump library-go #152

merged 1 commit into from Jan 19, 2024

Conversation

jsafrane
Copy link
Contributor

Update openshift/library-go and openshift/api to today's master. Update k8s deps to v0.29.0.
@openshift/storage

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 19, 2024 •
edited by openshift-ci bot

@jsafrane: This pull request references STOR-1574 which is a valid jira issue.

In response to this:

Update openshift/library-go and openshift/api to today's master. Update k8s deps to v0.29.0.
@openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 19, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 19, 2024
@jsafrane
Bump library-go
db58087 
Update openshift/library-go and openshift/api to today's master. Update k8s deps to v0.29.0.
@jsafrane
Copy link
Contributor Author

/label px-approved
/label docs-approved
No changes from user perspective
/label qe-approved
CI should be enough for library bumps

@openshift-ci openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR qe-approved Signifies that QE has signed off on this PR labels Jan 19, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 19, 2024 •
edited by openshift-ci bot

@jsafrane: This pull request references STOR-1574 which is a valid jira issue.

In response to this:

Update openshift/library-go and openshift/api to today's master. Update k8s deps to v0.29.0.
@openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jsafrane
Copy link
Contributor Author

/retest-required

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 19, 2024

@jsafrane: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-zones db58087 link false /test e2e-vsphere-zones

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

dobsonj
dobsonj reviewed Jan 19, 2024
View reviewed changes
pkg/operator/operatorclient.go
Comment on lines +87 to +95

func (c OperatorClient) GetOperatorStateWithQuorum(ctx context.Context) (*operatorv1.OperatorSpec, *operatorv1.OperatorStatus, string, error) {
instance, err := c.Client.Storages().Get(ctx, globalConfigName, metav1.GetOptions{})
if err != nil {
return nil, nil, "", err
}

return &instance.Spec.OperatorSpec, &instance.Status.OperatorStatus, instance.GetResourceVersion(), nil
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this for? I can't find where it's called, maybe I'm missing something.

Copy link
Member

@dobsonj dobsonj Jan 19, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nevermind, now I see it

vsphere-problem-detector/vendor/github.com/openshift/library-go/pkg/operator/v1helpers/helpers.go

Line 175 in db58087

_, oldStatus, resourceVersion, err = client.GetOperatorStateWithQuorum(ctx)

@dobsonj
Copy link
Member

dobsonj commented Jan 19, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 19, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit cc28e79 into openshift:master Jan 19, 2024
7 of 8 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-vsphere-problem-detector-container-v4.16.0-202401242108.p0.gcc28e79.assembly.stream for distgit vsphere-problem-detector.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dobsonj dobsonj dobsonj left review comments

@mpatlasov mpatlasov Awaiting requested review from mpatlasov

@tsmetana tsmetana Awaiting requested review from tsmetana

Assignees

@dobsonj dobsonj

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jsafrane @openshift-ci-robot @dobsonj @openshift-bot