Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1926943: Fix volume name length check #30

Merged

Conversation

jsafrane
Copy link
Contributor

@jsafrane jsafrane commented Feb 9, 2021

Use the same logic as Kubernetes to truncate cluster-id in volume names. This will fix false alerts when the cluster ID is too long.

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 9, 2021
Use the same logic as Kubernetes to truncate cluster-id in volume names.
This will fix false alerts when the cluster ID is too long.
@jsafrane jsafrane changed the title Fix volume name length check Bug 1926943: Fix volume name length check Feb 9, 2021
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Feb 9, 2021
@openshift-ci-robot
Copy link
Contributor

@jsafrane: This pull request references Bugzilla bug 1926943, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1926943: Fix volume name length check

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 9, 2021
@gnufied
Copy link
Member

gnufied commented Feb 9, 2021

/lgtm

1 similar comment
@gnufied
Copy link
Member

gnufied commented Feb 9, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 9, 2021
@gnufied
Copy link
Member

gnufied commented Feb 9, 2021

/retest

@openshift-merge-robot openshift-merge-robot merged commit 1c9d003 into openshift:master Feb 10, 2021
@openshift-ci-robot
Copy link
Contributor

@jsafrane: All pull requests linked via external trackers have merged:

Bugzilla bug 1926943 has been moved to the MODIFIED state.

In response to this:

Bug 1926943: Fix volume name length check

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants