[wip][downstream-test] Fix network status annotation to k8s.v1.cni.cncf.io/network-status #118
Conversation
Use the correct annotation string k8s.v1.cni.cncf.io/network-status directly from k8snetworkplumbingwg/network-attachment-definition-client Signed-off-by: Andreas Karis <ak.karis@gmail.com> (cherry picked from commit a0bbb1d)
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: andreaskaris The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
andreaskaris
changed the title
openshift-ci
bot
added
the
do-not-merge/work-in-progress
Signed-off-by: Andreas Karis <ak.karis@gmail.com> (cherry picked from commit 2e24269)
Signed-off-by: Andreas Karis <ak.karis@gmail.com>
andreaskaris
force-pushed
the
OCPBUGS-10328-downstream-testb
branch
from
3521c09
to
aed6aac
Compare
The podInformerFactory uses filter key spec.nodeName to filter the pods that it should monitor. Up until now, this filter was set to the value of HOSTNAME. However, this is not reliable, as spec.nodeName can be overridden in kubernetes with --hostname-override and thus HOSTNAME and spec.nodeName do not necessarily always match. Instead, rely on a new custom environment variable NODENAME which is populated by the downward API. Signed-off-by: Andreas Karis <ak.karis@gmail.com> (cherry picked from commit ef409bb)
andreaskaris
force-pushed
the
OCPBUGS-10328-downstream-testb
branch
from
123c41e
to
f3129bf
Compare
|
@andreaskaris: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Use the correct annotation string k8s.v1.cni.cncf.io/network-status directly from k8snetworkplumbingwg/network-attachment-definition-client
Signed-off-by: Andreas Karis ak.karis@gmail.com
(cherry picked from commit a0bbb1d)
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer (optional):