OCPBUGS-11322: respect requested allocation range when exluding ranges [Backport 4.13]

[nicklesimba]

What this PR does / why we need it:
This prevent overflowing outside the requested ipam.range when excluding ranges while the requested range is exhausted.

Also corrects a test where we expected to assign an IP outside of the expected range.

[openshift-ci]

@nicklesimba: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

respect requested allocation range when exluding ranges

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@nicklesimba: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

OCPBUGS-11322: respect requested allocation range when exluding ranges [Backport 4.13]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@nicklesimba: This pull request references Jira Issue OCPBUGS-11322, which is invalid:

• expected dependent Jira Issue OCPBUGS-11324 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

What this PR does / why we need it:
This prevent overflowing outside the requested ipam.range when excluding ranges while the requested range is exhausted.

Also corrects a test where we expected to assign an IP outside of the expected range.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@nicklesimba: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[zshi-redhat]

/jira refresh

[openshift-ci-robot]

@zshi-redhat: This pull request references Jira Issue OCPBUGS-11322, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.13.0) matches configured target version for branch (4.13.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
• dependent bug Jira Issue OCPBUGS-11324 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
• dependent Jira Issue OCPBUGS-11324 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0
• bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (weliang@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[zshi-redhat]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nicklesimba, zshi-redhat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [zshi-redhat]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dougbtv]

/label backport-risk-assessed

[jechen0648]

/label cherry-pick-approved

[openshift-ci-robot]

@nicklesimba: Jira Issue OCPBUGS-11322: All pull requests linked via external trackers have merged:

• openshift/whereabouts-cni#122
• openshift/whereabouts-cni#121

Jira Issue OCPBUGS-11322 has been moved to the MODIFIED state.

In response to this:

What this PR does / why we need it:
This prevent overflowing outside the requested ipam.range when excluding ranges while the requested range is exhausted.

Also corrects a test where we expected to assign an IP outside of the expected range.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.