Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 16002: Change default binary to RHEL8 image #172

Merged
merged 1 commit into from Aug 4, 2023

Conversation

dcbw
Copy link

@dcbw dcbw commented Aug 4, 2023

OCP4.13 container image is RHEL8 based image, so need to change default binary in /usr/src/whereabous/bin to RHEL8.

Cherry-pick of #144

OCP4.13 container image is RHEL8 based image, so need to change
default binary in /usr/src/whereabous/bin to RHEL8.
@dcbw dcbw requested a review from dougbtv as a code owner August 4, 2023 17:50
@openshift-ci openshift-ci bot requested a review from fepan August 4, 2023 17:51
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 4, 2023
Copy link
Member

@mrunalp mrunalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 4, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dcbw, mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 4, 2023

@dcbw: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 7e45436 into openshift:master Aug 4, 2023
3 checks passed
neisw added a commit to neisw/whereabouts-cni that referenced this pull request Aug 6, 2023
This reverts commit 7e45436, reversing
changes made to d5a9ab3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants