Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overlapping Ranges support #18

Merged
merged 17 commits into from Jul 27, 2020
Merged

Overlapping Ranges support #18

merged 17 commits into from Jul 27, 2020

Conversation

dougbtv
Copy link
Member

@dougbtv dougbtv commented Jul 23, 2020

No description provided.

dougbtv and others added 17 commits January 22, 2020 15:29
@dougbtv
Updates Dockerfile.openshift to use the vendor dir
779c77e
@dougbtv
Merge pull request #31 from dougbtv/dockerfile-openshift-go-vendor
7263a7f 
Updates Dockerfile.openshift to use the vendor dir
@dougbtv
Updates travis to build Dockerfile.openshift
1bdf149
@dougbtv
Merge pull request #32 from dougbtv/travis-openshift-build
d3c8d8e 
Updates travis to build Dockerfile.openshift
@dougbtv
Updates CRD name to whereabouts.cni.cncf.io
2cffdc6
@dougbtv
Merge pull request #33 from dougbtv/update-crd-namespace
d559a15 
Updates CRD name to whereabouts.cni.cncf.io
@crandles
range_end should be treated as inclusive when iterating for ip assign…
b2fb1ae 
…ments
@crandles
Merge pull request #36 from crandles/inclusive-range-end
9e4ea85 
range_end should be treated as inclusive when iterating for ip assignments
@aneeshkp
Fixed For whereabouts DHCP testing, if setup range: 192.168.21.100/3…
523a36a 
…0 in yaml file, then 192.168.22.100/30 is network address, 192.168.22.101/30 to 192.168.22.102/30 are host addresses, 192.168.22.103/30 is broadcast address, the pod should only get 192.168.22.101 and 192.168.22.102, but right now one pod can get network address 192.168.22.100
@dougbtv
Merge pull request #41 from aneeshkp/range-check
0fbc354 
Fixed to drop broadcast and first network address when the range is cidr
@crandles
fix range_end logic and add tests
5ad66b5
@dougbtv
Merge pull request #43 from crandles/fix-range-end
d879bd8 
fix range_end logic and add tests
Make ds use hostNetwork by default
59e8631 
This patch makes whereabouts pods deployed as ds to use
hostNetwork by default. This is helpful as CNI and core
infra components use hostnetwork and hence avoid issues
such as fault in CNI config etc and also making debugging
much easier.
@dougbtv
Merge pull request #45 from ashish-billore/deploy-option
158a70d 
Make ds use hostNetwork by default
@dougbtv
[overlappingranges] Adds functionality for overlapping ranges
1e6ed41
@dougbtv
Merge pull request #49 from dougbtv/overlapping-ranges
6ee591f 
Feature: Adds functionality for overlapping ranges
@dougbtv
Merge branch 'release-v0.4' into HEAD to update for overlapping range…
b8696eb 
…s support
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2020
@dougbtv
Copy link
Member Author

dougbtv commented Jul 27, 2020

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 27, 2020
@s1061123
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dougbtv, s1061123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dougbtv
Copy link
Member Author

dougbtv commented Jul 27, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 27, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 08211e4 into master Jul 27, 2020
@dougbtv dougbtv deleted the overlapping-ip-ranges-ocp-46 branch July 31, 2020 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fepan fepan Awaiting requested review from fepan

@s1061123 s1061123 Awaiting requested review from s1061123

Assignees

@s1061123 s1061123

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@dougbtv @s1061123 @openshift-ci-robot @openshift-bot @openshift-merge-robot @crandles @aneeshkp