Bug 1931953: [backport 4.6] Fix for IPv6 when leading hextets equal zero #50

dougbtv · 2021-02-23T16:22:18Z

Also has fixes for the duplicate IP address bz for 4.6 @ https://bugzilla.redhat.com/show_bug.cgi?id=1944682

openshift-ci-robot · 2021-02-23T16:22:24Z

@dougbtv: This pull request references Bugzilla bug 1931953, which is invalid:

expected dependent Bugzilla bug 1919048 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead
expected dependent Bugzilla bug 1931950 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ASSIGNED instead
expected dependent Bugzilla bug 1919048 to target a release in 4.7.0, but it targets "4.8.0" instead
expected dependent Bugzilla bug 1931950 to target a release in 4.7.0, but it targets "4.7.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

s1061123 · 2021-02-24T13:11:31Z

/lgtm

openshift-bot · 2021-02-25T01:00:13Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-02-25T01:00:18Z

@openshift-bot: This pull request references Bugzilla bug 1931953, which is invalid:

expected dependent Bugzilla bug 1919048 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead
expected dependent Bugzilla bug 1931950 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ASSIGNED instead
expected dependent Bugzilla bug 1919048 to target a release in 4.7.0, 4.7.z, but it targets "4.8.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-02-26T01:00:25Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-02-26T01:00:36Z

@openshift-bot: This pull request references Bugzilla bug 1931953, which is invalid:

expected dependent Bugzilla bug 1919048 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead
expected dependent Bugzilla bug 1931950 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ASSIGNED instead
expected dependent Bugzilla bug 1919048 to target a release in 4.7.0, 4.7.z, but it targets "4.8.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-02-27T01:00:38Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-02-27T01:00:43Z

@openshift-bot: This pull request references Bugzilla bug 1931953, which is invalid:

expected dependent Bugzilla bug 1919048 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead
expected dependent Bugzilla bug 1931950 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ASSIGNED instead
expected dependent Bugzilla bug 1919048 to target a release in 4.7.0, 4.7.z, but it targets "4.8.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-02-28T01:00:48Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-02-28T01:00:53Z

@openshift-bot: This pull request references Bugzilla bug 1931953, which is invalid:

expected dependent Bugzilla bug 1919048 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead
expected dependent Bugzilla bug 1931950 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ASSIGNED instead
expected dependent Bugzilla bug 1919048 to target a release in 4.7.0, 4.7.z, but it targets "4.8.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-03-01T01:00:39Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-03-01T01:00:45Z

@openshift-bot: This pull request references Bugzilla bug 1931953, which is invalid:

expected dependent Bugzilla bug 1919048 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead
expected dependent Bugzilla bug 1931950 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ASSIGNED instead
expected dependent Bugzilla bug 1919048 to target a release in 4.7.0, 4.7.z, but it targets "4.8.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-03-02T01:00:33Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-03-02T01:00:41Z

@openshift-bot: This pull request references Bugzilla bug 1931953, which is invalid:

expected dependent Bugzilla bug 1931950 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ASSIGNED instead
expected dependent Bugzilla bug 1919048 to target a release in 4.7.0, 4.7.z, but it targets "4.8.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-03-03T01:00:59Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-03-03T01:01:04Z

@openshift-bot: This pull request references Bugzilla bug 1931953, which is invalid:

expected dependent Bugzilla bug 1931950 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead
expected dependent Bugzilla bug 1919048 to target a release in 4.7.0, 4.7.z, but it targets "4.8.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-03-04T01:00:49Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-03-04T01:00:54Z

@openshift-bot: This pull request references Bugzilla bug 1931953, which is invalid:

expected dependent Bugzilla bug 1931950 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead
expected dependent Bugzilla bug 1919048 to target a release in 4.7.0, 4.7.z, but it targets "4.8.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-03-05T01:00:27Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-03-05T01:00:32Z

@openshift-bot: This pull request references Bugzilla bug 1931953, which is invalid:

expected dependent Bugzilla bug 1931950 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead
expected dependent Bugzilla bug 1919048 to target a release in 4.7.0, 4.7.z, but it targets "4.8.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-03-06T01:01:19Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-03-06T01:01:23Z

@openshift-bot: This pull request references Bugzilla bug 1931953, which is invalid:

expected dependent Bugzilla bug 1931950 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead
expected dependent Bugzilla bug 1919048 to target a release in 4.7.0, 4.7.z, but it targets "4.8.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-03-07T01:01:11Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-bot · 2021-03-30T07:42:09Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-03-30T09:39:12Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-03-30T10:57:15Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-03-30T11:23:54Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-03-30T12:02:14Z

/retest

Please review the full test history for this PR and help us cut down flakes.

dougbtv · 2021-03-30T13:43:22Z

/bugzilla refresh

openshift-ci-robot · 2021-03-30T13:43:27Z

@dougbtv: This pull request references Bugzilla bug 1931953, which is invalid:

expected dependent Bugzilla bug 1919048 to target a release in 4.7.0, 4.7.z, but it targets "4.8.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This updates the README to link to the upstream project source.

This removes the logic that was IPv4 based for removing the broadcast address. [IPv6 does not implement broadcast](https://en.wikipedia.org/wiki/IPv6_address#Addressing_methods). It also adds a unit test to validate that, as well as updates some checks which wrongly assumed the broadcast address omission.

This code removes bigint from pkg/allocate because it may causes various problem.

openshift-ci-robot · 2021-03-30T13:54:15Z

@dougbtv: This pull request references Bugzilla bug 1931953, which is invalid:

expected dependent Bugzilla bug 1919048 to target a release in 4.7.0, 4.7.z, but it targets "4.8.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dougbtv · 2021-03-30T13:56:04Z

/bugzilla refresh

openshift-ci-robot · 2021-03-30T13:57:12Z

@dougbtv: An error was encountered querying GitHub for users with public email (weliang@redhat.com) for bug 1931953 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message.


non-200 OK status code: 403 Forbidden body: "{\n  \"documentation_url\": \"https://docs.github.com/en/free-pro-team@latest/rest/overview/resources-in-the-rest-api#abuse-rate-limits\",\n  \"message\": \"You have triggered an abuse detection mechanism. Please wait a few minutes before you try again.\"\n}\n"

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dougbtv · 2021-03-30T14:00:11Z

/bugzilla refresh

openshift-ci-robot · 2021-03-30T14:00:20Z

@dougbtv: This pull request references Bugzilla bug 1931953, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.z) matches configured target release for branch (4.6.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1931950 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
dependent Bugzilla bug 1931950 targets the "4.7.z" release, which is one of the valid target releases: 4.7.0, 4.7.z
bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (weliang@redhat.com), skipping review request.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

s1061123 · 2021-03-30T14:03:57Z

/lgtm

s1061123 · 2021-03-30T14:04:08Z

/lgtm

openshift-ci-robot · 2021-03-30T14:04:18Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dougbtv, s1061123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [dougbtv,s1061123]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2021-04-09T20:48:03Z

@dougbtv: All pull requests linked via external trackers have merged:

openshift/whereabouts-cni#50

Bugzilla bug 1931953 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Feb 23, 2021

openshift-ci-robot requested review from dcbw and fepan February 23, 2021 16:22

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 23, 2021

openshift-ci-robot assigned s1061123 Feb 24, 2021

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 24, 2021

dougbtv and others added 7 commits March 30, 2021 09:47

The README should direct users to the upstream source.

beb54b4

This updates the README to link to the upstream project source.

Update x/text

01a18f5

[WIP] Has unit tests and debug output for starts-with-zero-ipv6-problem

8b8d494

Remove bigint code to fix starts-with-zero-ipv6-problem

f7a5fb2

This code removes bigint from pkg/allocate because it may causes various problem.

Update method names and unit test descriptions

1e63872

Fix IP address type size to 16 bytes

306e6ab

dougbtv force-pushed the ocp-4.6-ipv6-fix branch from 06480ba to 306e6ab Compare March 30, 2021 13:53

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 30, 2021

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Mar 30, 2021

openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Mar 30, 2021

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 30, 2021

russellb added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 9, 2021

openshift-merge-robot merged commit 577a9f8 into release-4.6 Apr 9, 2021

Bug 1931953: [backport 4.6] Fix for IPv6 when leading hextets equal zero #50

Bug 1931953: [backport 4.6] Fix for IPv6 when leading hextets equal zero #50

Conversation

dougbtv commented Feb 23, 2021 • edited

openshift-ci-robot commented Feb 23, 2021

s1061123 commented Feb 24, 2021

openshift-bot commented Feb 25, 2021

openshift-ci-robot commented Feb 25, 2021

openshift-bot commented Feb 26, 2021

openshift-ci-robot commented Feb 26, 2021

openshift-bot commented Feb 27, 2021

openshift-ci-robot commented Feb 27, 2021

openshift-bot commented Feb 28, 2021

openshift-ci-robot commented Feb 28, 2021

openshift-bot commented Mar 1, 2021

openshift-ci-robot commented Mar 1, 2021

openshift-bot commented Mar 2, 2021

openshift-ci-robot commented Mar 2, 2021

openshift-bot commented Mar 3, 2021

openshift-ci-robot commented Mar 3, 2021

openshift-bot commented Mar 4, 2021

openshift-ci-robot commented Mar 4, 2021

openshift-bot commented Mar 5, 2021

openshift-ci-robot commented Mar 5, 2021

openshift-bot commented Mar 6, 2021

openshift-ci-robot commented Mar 6, 2021

openshift-bot commented Mar 7, 2021

openshift-bot commented Mar 30, 2021

openshift-bot commented Mar 30, 2021

openshift-bot commented Mar 30, 2021

openshift-bot commented Mar 30, 2021

openshift-bot commented Mar 30, 2021

dougbtv commented Mar 30, 2021

openshift-ci-robot commented Mar 30, 2021

openshift-ci-robot commented Mar 30, 2021

dougbtv commented Mar 30, 2021

openshift-ci-robot commented Mar 30, 2021

dougbtv commented Mar 30, 2021

openshift-ci-robot commented Mar 30, 2021

s1061123 commented Mar 30, 2021

s1061123 commented Mar 30, 2021

openshift-ci-robot commented Mar 30, 2021

openshift-ci-robot commented Apr 9, 2021

dougbtv commented Feb 23, 2021 •

edited