Reconciler: kubeconfig update #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Define the reconciler as a system critical resource. Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
With this change the reconciler can run in two different ways: - when ran in a k8s pod, it does not require to be told how to connect to the cluster. - when ran as a binary, it does require to know how to connect to the cluster, via the -kubeconfig config option. The reconciler cron spec is updated to use the correct service account name, and also is updated to run in the `kube-system` namespace. Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
All (non error) logs have the same verbosity; it would be interesting to see the reconciled IPs by default, as such I'm bumping this particular logging call to `verbose`. That enables users to `kubectl logs <reconciler-pod-name` and see which IP addresses got reconciled. The below calls would be bumped to `verbose`. ``` 2021-10-20T15:50:00Z [debug] removed stale overlappingIP allocation [10.10.0.100] 2021-10-20T15:50:00Z [debug] removed stale overlappingIP allocation [10.10.0.111] 2021-10-20T15:50:00Z [debug] removed stale overlappingIP allocation [10.10.0.113] 2021-10-20T15:50:00Z [debug] removed stale overlappingIP allocation [10.10.0.118] 2021-10-20T15:50:00Z [debug] removed stale overlappingIP allocation [10.10.0.13] 2021-10-20T15:50:00Z [debug] removed stale overlappingIP allocation [10.10.0.170] 2021-10-20T15:50:00Z [debug] removed stale overlappingIP allocation [10.10.0.18] 2021-10-20T15:50:00Z [debug] removed stale overlappingIP allocation [10.10.0.3] 2021-10-20T15:50:00Z [debug] removed stale overlappingIP allocation [10.10.0.35] 2021-10-20T15:50:00Z [debug] removed stale overlappingIP allocation [10.10.0.4] 2021-10-20T15:50:01Z [debug] removed stale overlappingIP allocation [10.10.0.83] ``` Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
openshift-ci
bot
added
the
approved
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dougbtv, s1061123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-robot
pushed a commit
that referenced
this pull request
Feb 3, 2022
Includes fix for excluding IPv6 ranges as well as unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also brings in the change for the upstream github namespace change, this was the first set of downstream changes that relied on those.