-
Notifications
You must be signed in to change notification settings - Fork 36
Bug 1805513: Resolve parallel execution of playbook #154
Bug 1805513: Resolve parallel execution of playbook #154
Conversation
@akhil-rane: This pull request references Bugzilla bug 1805513, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
chdir: "{{ project_root }}" | ||
|
||
- name: Move WMCB to temporary directory | ||
command: mv "{{ project_root }}/{{ wmcb_exe }}" "{{ tmp_dir.path }}/{{ wmcb_exe }}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couldn't you fix it by copying the file instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could, but that will leave a copy of wmcb.exe in the project root directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that a problem? Space is cheap 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Thanks for fixing this @akhil-rane. Please squash your commits and while squashing update the solution in the PR and commit message
/bugzilla refresh |
@aravindhp: This pull request references Bugzilla bug 1805513, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Problem: When we run wsu playbook parallely for 2 windows vms, the ansible task 'Move wmcb to temporary directory' fails for the second vm. This is because currently we are building wmcb.exe in the project root directory in both the runs. So when the run for the first vm has moved the built wmcb.exe to a temporary directory, run for the second vm cannot find it. Solution: Instead of moving built wmcb.exe to a temporary directory, we are copying it
cfba449
to
eb01a10
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akhil-rane, aravindhp, suhanime The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@akhil-rane: This pull request references Bugzilla bug 1805513, which is valid. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest Please review the full test history for this PR and help us cut down flakes. |
7 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
@akhil-rane: All pull requests linked via external trackers have merged. Bugzilla bug 1805513 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Problem: When we run wsu playbook parrallely for 2 windows vms, the ansible task
'Move wmcb to temporary directory' fails for the second vm. This is because
currently we are building wmcb.exe in the project root directory in both the runs.
So when the run for the first vm has moved the built wmcb.exe to a temporary
directory, run for the second vm cannot find it.
Solution: Instead of moving built wmcb.exe to a temporary directory, we are
copying it