Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

Bug 1805513: Resolve parallel execution of playbook #154

Conversation

akhil-rane
Copy link

@akhil-rane akhil-rane commented Feb 21, 2020

Problem: When we run wsu playbook parrallely for 2 windows vms, the ansible task
'Move wmcb to temporary directory' fails for the second vm. This is because
currently we are building wmcb.exe in the project root directory in both the runs.
So when the run for the first vm has moved the built wmcb.exe to a temporary
directory, run for the second vm cannot find it.

Solution: Instead of moving built wmcb.exe to a temporary directory, we are
copying it

@openshift-ci-robot
Copy link

@akhil-rane: This pull request references Bugzilla bug 1805513, which is invalid:

  • expected the bug to target the "4.5.0" release, but it targets "4.4.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1805513: Resolve parrallel execution of playbook

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 21, 2020
chdir: "{{ project_root }}"

- name: Move WMCB to temporary directory
command: mv "{{ project_root }}/{{ wmcb_exe }}" "{{ tmp_dir.path }}/{{ wmcb_exe }}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't you fix it by copying the file instead?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could, but that will leave a copy of wmcb.exe in the project root directory.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that a problem? Space is cheap 😉

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed this

Copy link
Contributor

@aravindhp aravindhp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Thanks for fixing this @akhil-rane. Please squash your commits and while squashing update the solution in the PR and commit message

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2020
@aravindhp
Copy link
Contributor

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 21, 2020
@openshift-ci-robot
Copy link

@aravindhp: This pull request references Bugzilla bug 1805513, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 21, 2020
Problem: When we run wsu playbook parallely for 2 windows vms, the ansible task
'Move wmcb to temporary directory' fails for the second vm. This is because
currently we are building wmcb.exe in the project root directory in both the runs.
So when the run for the first vm has moved the built wmcb.exe to a temporary
directory, run for the second vm cannot find it.

Solution: Instead of moving built wmcb.exe to a temporary directory, we are
copying it
@akhil-rane akhil-rane force-pushed the fix_parrallel_wsu_playbook_execution branch from cfba449 to eb01a10 Compare February 21, 2020 19:33
@suhanime
Copy link
Contributor

/lgtm
Thank you for the PR @akhil-rane

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akhil-rane, aravindhp, suhanime

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@akhil-rane akhil-rane changed the title Bug 1805513: Resolve parrallel execution of playbook Bug 1805513: Resolve parallel execution of playbook Feb 21, 2020
@openshift-ci-robot
Copy link

@akhil-rane: This pull request references Bugzilla bug 1805513, which is valid.

In response to this:

Bug 1805513: Resolve parallel execution of playbook

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit a6f911b into openshift:master Feb 22, 2020
@openshift-ci-robot
Copy link

@akhil-rane: All pull requests linked via external trackers have merged. Bugzilla bug 1805513 has been moved to the MODIFIED state.

In response to this:

Bug 1805513: Resolve parallel execution of playbook

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants