Bug 1841140: fix getting kube node binary SHA #204
Conversation
This PR fixes two issues encountered while running WSU with kube version v1.18.3+144c666. The redundant part in the kube version needs to be trimmed to get the correct kubernetes version in the grep command. In addition, since the output of the curl command is no longer in <td><code>...</code></td> format but in <td>...</td> format the sha needs to be extracted accordingly.
openshift-ci-robot
added
bugzilla/severity-high
|
@mansikulkarni96: This pull request references Bugzilla bug 1841140, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
|
@mansikulkarni96: This pull request references Bugzilla bug 1841140, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
|
@mansikulkarni96: This pull request references Bugzilla bug 1841140, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Thanks @mansikulkarni96 for working on this. Please address my comment
| @@ -46,7 +46,7 @@ | |||
| shell: | | |||
| curl -s "{{ changelog.stdout }}" | \ | |||
| grep -A 1 "{{ kubernetes_version.stdout }}" | \ | |||
| grep -A 1 node-windows | tail -n 1 | sed -e 's/.*<code>\(.*\)<\/code>.*/\1/' | |||
| grep -A 1 node-windows | tail -n 1 | sed -e 's/.*<code>\(.*\)<\/code>.*/\1/'| sed -e 's/.*<td>\(.*\)<\/td>.*/\1/' | |||
There was a problem hiding this comment.
If <code> is not in the curl command, we should just use grep -A 1 node-windows | tail -n 1 | sed -e 's/.*<td>\(.*\)<\/td>.*/\1/'
There was a problem hiding this comment.
this is to ensure this works on 4.4, the releases before 1.18.3 contain <code>
openshift-ci-robot
added
the
approved
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aravindhp, mansikulkarni96, VaishnaviHire The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
@mansikulkarni96: All pull requests linked via external trackers have merged: openshift/windows-machine-config-bootstrapper#204. Bugzilla bug 1841140 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR fixes two issues encountered while running
WSU with kube version v1.18.3+144c666. The redundant
part in the kube version needs to be trimmed to get the
correct kubernetes version in the grep command.
In addition, since the output of the curl command is no
longer in
<td><code>...</code></td>format but in<td>...</td>format the sha needs to be extractedaccordingly.