WINC-602: [wmcb] Support Windows Server 2022 #316
Conversation
|
But the same Pause will be used now in other windows server version too. Can we make PR title generic like "Upgrade Pause image to 3.6" |
|
/approve |
| @@ -46,7 +46,7 @@ const ( | |||
| // this is used to parse the kubelet args | |||
| kubeletSystemdName = "kubelet.service" | |||
| // kubeletPauseContainerImage is the location of the image we will use for the kubelet pause container | |||
| kubeletPauseContainerImage = "mcr.microsoft.com/oss/kubernetes/pause:3.4.1" | |||
| kubeletPauseContainerImage = "mcr.microsoft.com/oss/kubernetes/pause:3.6" | |||
There was a problem hiding this comment.
Should we be using 3.5 since we're still on 1.22?
There was a problem hiding this comment.
Best to always stay at the latest to catch base image fixes.
There was a problem hiding this comment.
I don't think pause images are tied to a specific kube version
There was a problem hiding this comment.
I thought they might be because of this doc: https://kubernetes.io/docs/setup/production-environment/windows/intro-windows-in-kubernetes/#pause-container
But makes sense to have latest. I'm ok with 3.6
There was a problem hiding this comment.
We should keep in mind we are moving to the version that adds support for 2022. 3.5 might not support it.
@selansen this is the pattern we have been following. Please see #258. We want to call out that we are adding support for a new Windows version explicitly by upgrading the pause image. |
openshift-ci
bot
added
the
approved
|
/lgtm |
|
/test e2e-wmcb |
|
/lgtm |
1 similar comment
|
/lgtm |
|
/hold Until we figure out the hybrid-overlay test failure |
openshift-ci
bot
added
the
do-not-merge/hold
|
/lgtm |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/hold unit test is failing due to a change introduced in this PR. |
openshift-ci
bot
added
the
do-not-merge/hold
This requires upgrading the pause image to 3.6 which has support for Windows Server 2022.
saifshaikh48
force-pushed
the
windows-server-2022-support
branch
from
462ece2
to
4bcba7d
Compare
|
/hold cancel Unit test has been fixed |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alinaryan, jrvaldes, mansikulkarni96, saifshaikh48, sebsoto, selansen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-4.10 |
|
@saifshaikh48: once the present PR merges, I will cherry-pick it on top of release-4.10 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.9 |
|
@saifshaikh48: once the present PR merges, I will cherry-pick it on top of release-4.9 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick community-4.9 |
|
@saifshaikh48: once the present PR merges, I will cherry-pick it on top of community-4.9 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@saifshaikh48: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@saifshaikh48: new pull request created: #332 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@saifshaikh48: new pull request created: #333 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@saifshaikh48: new pull request created: #334 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick community-4.8 |
|
/cherry-pick release-4.8 |
|
@saifshaikh48: new pull request created: #335 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@saifshaikh48: new pull request created: #336 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This requires upgrading the pause image to 3.6
which has support for Windows Server 2022.