Skip to content

Commit

Permalink
[e2e] Check version anno in upgrade test
Browse files Browse the repository at this point in the history
This change enables the version annotation check while waiting for the
Windows nodes to be fully configured after triggering an upgrade.

Before, both nodes were getting configured at the same time so this
wasn't an issue, but now with the sequential order of the upgrade
process WMCO takes some time to start processing the next node and
the test was failing due to version annotation mismatch.

(cherry picked from commit 32ab771)
  • Loading branch information
jrvaldes committed Feb 19, 2024
1 parent 0a99dc1 commit 57aab27
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions test/e2e/upgrade_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -214,9 +214,9 @@ func TestUpgrade(t *testing.T) {
err = tc.scaleMachineApprover(1)
require.NoError(t, err)

err = tc.waitForConfiguredWindowsNodes(int32(numberOfMachineNodes), false, false)
err = tc.waitForConfiguredWindowsNodes(int32(numberOfMachineNodes), true, false)
assert.NoError(t, err, "timed out waiting for Windows Machine nodes")
err = tc.waitForConfiguredWindowsNodes(int32(numberOfBYOHNodes), false, true)
err = tc.waitForConfiguredWindowsNodes(int32(numberOfBYOHNodes), true, true)
assert.NoError(t, err, "timed out waiting for BYOH Windows nodes")

// Basic testing to ensure the Node object is in a good state
Expand Down

0 comments on commit 57aab27

Please sign in to comment.