Merge pull request #2030 from openshift-cherrypick-robot/cherry-pick-…

…2025-to-release-4.15

[release-4.15] [test] Open SMB port when creating share

test/e2e/storage_test.go

@@ -91,8 +91,16 @@ func (tc *testContext) createSMBPV() (*core.PersistentVolume, error) {
 	}
 	node := gc.allNodes()[0]
 	addr, err := controllers.GetAddress(node.Status.Addresses)
+	if err != nil {
+		return nil, fmt.Errorf("error getting address: %w", err)
+	}
+	openSMBPortCommand := "New-NetFirewallRule -DisplayName 'SMB' -Direction Inbound -Action Allow -Protocol TCP " +
+		"-LocalPort 445 -EdgeTraversalPolicy Allow"
+	if out, err := tc.runPowerShellSSHJob("open-smb-port", openSMBPortCommand, addr); err != nil {
+		return nil, fmt.Errorf("error opening SMB port %s: %w", out, err)
+	}
 	if err := tc.checkSMBPortOpen(addr); err != nil {
-		return nil, fmt.Errorf("port unreachable")
+		return nil, fmt.Errorf("smb port unreachable")
 	}
 	username := "SMBUser"
 	password := generateWindowsPassword()
@@ -101,9 +109,6 @@ func (tc *testContext) createSMBPV() (*core.PersistentVolume, error) {
 		"New-LocalUser -Name '%s' -Password $Password;"+
 		"mkdir /smbshare;"+
 		"New-SmbShare -Name '%s' -Path C:\\smbshare -FullAccess '%s'", password, username, shareName, username)
-	if err != nil {
-		return nil, fmt.Errorf("error getting address: %w", err)
-	}
 	if out, err := tc.runPowerShellSSHJob("create-smb-share", createShareCommand, addr); err != nil {
 		return nil, fmt.Errorf("error creating SMB share %s: %w", out, err)
 	}